Skip to content
Snippets Groups Projects

Issue #3122526: Pager links inside a modal do not open in the modal

Open Issue #3122526: Pager links inside a modal do not open in the modal
1 unresolved thread
Open Adam Bramley requested to merge issue/drupal-3122526:3122526-pager-links-inside into 11.x
1 unresolved thread

Merge request reports

Members who can merge are allowed to add commits.
Approval is optional
Code Quality is loading
Test summary results are being parsed
Metrics reports are loading
Ready to merge by members who can write to the target branch.
  • The source branch is 142 commits behind the target branch.
  • 1 commit will be added to 11.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1732 1733 $route_name = $variables['pager']['#route_name'];
    1733 1734 $route_parameters = $variables['pager']['#route_parameters'] ?? [];
    1734 1735
    1736 $link_attributes = [];
    1737 if (\Drupal::hasRequest() && \Drupal::request()->get(MainContentViewSubscriber::WRAPPER_FORMAT) === 'drupal_modal') {
    • Did you have a specific reason why you decided to add this to the preprocess function instead of the render element? To me this seems more like something that would be managed by the render element.

    • How would we do it in the render element? This preprocess is what's creating the link elements

    • Please register or sign in to reply
  • Michael Strelan added 464 commits

    added 464 commits

    Compare with previous version

  • Adam Bramley added 186 commits

    added 186 commits

    Compare with previous version

  • Adam Bramley changed the description

    changed the description

  • Adam Bramley changed target branch from 10.1.x to 11.x

    changed target branch from 10.1.x to 11.x

  • Adam Bramley added 199 commits

    added 199 commits

    Compare with previous version

  • Adam Bramley added 232 commits

    added 232 commits

    Compare with previous version

  • Adam Bramley added 454 commits

    added 454 commits

    • d1e47526...57ca853a - 453 commits from branch project:11.x
    • 75e5a0d5 - Merge remote-tracking branch 'origin/11.x' into 3122526-pager-links-inside

    Compare with previous version

  • Adam Bramley added 1 commit
  • Adam Bramley added 1 commit

    added 1 commit

    • de5aa312 - Assert we are still in the modal after paginating

    Compare with previous version

  • Adam Bramley added 1 commit

    added 1 commit

    Compare with previous version

  • added 1108 commits

    Compare with previous version

  • Adam Bramley added 1085 commits

    added 1085 commits

    Compare with previous version

  • Adam Bramley added 1 commit

    added 1 commit

    Compare with previous version

  • Adam Bramley added 1 commit

    added 1 commit

    • ca18c9dd - Stark no longer has a themed pager

    Compare with previous version

  • Stephen Mustgrave
  • Adam Bramley added 196 commits

    added 196 commits

    Compare with previous version

  • Adam Bramley added 191 commits

    added 191 commits

    Compare with previous version

  • Adam Bramley added 54 commits

    added 54 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading