Skip to content
Snippets Groups Projects

Keep machine name generation after both HTML and non-HTML validation failure + tests

Closed Harumi Jang requested to merge issue/drupal-3038141:3038141-machine into 10.1.x
1 unresolved thread

Closes #3038141

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lauri Timmanee
  • Harumi Jang added 52 commits

    added 52 commits

    • 7da8d48b...09a5ff9f - 50 commits from branch project:10.1.x
    • 8c714e8a - Keep machine name generation after both HTML and non-HTML validation failure + tests
    • 91af5e94 - Add non empty condition for error check and separate test

    Compare with previous version

  • Harumi Jang added 1 commit

    added 1 commit

    Compare with previous version

  • Harumi Jang added 1 commit

    added 1 commit

    Compare with previous version

  • Lauri Timmanee added 138 commits

    added 138 commits

    • 15549fbf...f8ac8262 - 134 commits from branch project:10.1.x
    • 5dfd3675 - Keep machine name generation after both HTML and non-HTML validation failure + tests
    • f5be07fd - Add non empty condition for error check and separate test
    • 2f04d0cf - Add line in comment
    • 9fdd1e2d - Remove empty check

    Compare with previous version

  • 178 183 }
    179 184
    180 185 // Add a listener for an invalid event on the machine name input
    181 // to show its container and focus it.
    182 $target.on('invalid', eventData, clickEditHandler);
    186 // to keep the generated machine name.
    187 $target.on('invalid', eventData, machineNameHandler);
  • Harumi Jang added 1 commit

    added 1 commit

    Compare with previous version

  • Harumi Jang added 111 commits

    added 111 commits

    • 90b3e2c7...67fd5e83 - 106 commits from branch project:10.1.x
    • 17720611 - Keep machine name generation after both HTML and non-HTML validation failure + tests
    • d7abcd5f - Add non empty condition for error check and separate test
    • f5e76c44 - Add line in comment
    • 6a5205f4 - Remove empty check
    • f9d681d8 - Remove event handler

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • 98230c49 - add 'exists' to FormTestMachineNameForm.php

    Compare with previous version

  • Harumi Jang added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins
  • Ben Mullins added 20 commits

    added 20 commits

    • df0ba7d1 - Issue #3348592 by alexpott, kunal_sahu, joseph.olstad, catch, larowlan,...
    • 978f1a16 - Revert "Issue #3337513 by mondrake, gidarai, daffie, alexpott, catch: Fix...
    • 4bca6e80 - Issue #3344083 by longwave, lauriii, Wim Leers, smustgrave: Update CKEditor 5 to 36.0.1
    • 3af2e665 - Issue #2987444 by hooroomoo, lauriii, bnjmnm, alwaysworking, tim.plunkett,...
    • 8f729603 - Issue #3307409 by mherchel, heddn, gquisini, Phoenixbros, bbu23: Setting media...
    • 923926dc - Issue #3348851 by andypost: Deprecate drupal_theme_rebuild()
    • cb21cfe2 - Issue #3278144 by ressa, Rinku Jacob 13, Akshay kashyap, Gauravvvv: Remove...
    • a0e038f5 - Issue #3350058 by Rinku Jacob 13: Remove quotes from claro.info.yml
    • 31ffa0b0 - Issue #2944089 by msankhala, smustgrave, lauriii, Ada Hernandez, TanujJain-TJ,...
    • 582bc514 - Issue #3266544 by Spokje, xjm, smustgrave, bbrala, catch: Remove remaining...
    • eeb88731 - Issue #3191391 by Arantxio, larowlan, _utsavsharma, daffie:...
    • 4748572c - Issue #3347766 by Spokje, smustgrave: Address @todo-comments linking to closed issue [#3219959]
    • 6a12ff0a - Issue #2958649 by acbramley, moshe weitzman, fenstrat: Incorrect totals count...
    • 0ee4d371 - Issue #3264195 by quietone, joshua1234511, phenaproxima, smustgrave: Move...
    • 68a78883 - Issue #3348848 by andypost, Purencool, daffie: Deprecate theme_get_registry()
    • d8d64dd0 - Issue #3331870 by Chris64, PrabuEla, smustgrave, cilefen: Code error url...
    • 4eb34336 - Issue #2602326 by Rassoni, Rishabh Vishwakarma, heykarthikwithu, paulocs,...
    • 626b4a40 - Issue #3245252 by andypost, ranjith_kumar_k_u, Spokje: Fix possibly undefined...
    • e1bdc2ef - Issue #3348092 by andypost, alexpott, Ranjit1032002, smustgrave, catch:...
    • a4f62638 - Issue #3350400 by mondrake: Remove DrupalStandardsListenerTrait - it's broken,...

    Compare with previous version

  • Ben Mullins added 46 commits

    added 46 commits

    Compare with previous version

  • Lauri Timmanee added 1 commit

    added 1 commit

    • 63f3dcc5 - Simplify \Drupal\form_test\Form\FormTestMachineNameForm::load

    Compare with previous version

  • Ben Mullins added 58 commits

    added 58 commits

    • 63f3dcc5...5f167385 - 56 commits from branch project:10.1.x
    • bdb4cc01 - Merge remote-tracking branch 'origin/10.1.x' into 3038141-machine
    • 6ea37c95 - only add require if it was there to begin with

    Compare with previous version

  • Lauri Timmanee added 1 commit

    added 1 commit

    Compare with previous version

  • Lauri Timmanee added 1 commit

    added 1 commit

    Compare with previous version

  • Lauri Timmanee added 1 commit
  • closed

  • Please register or sign in to reply
    Loading