Issue #3268809: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine'
Merge request reports
Activity
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
6 6 use Drupal\KernelTests\KernelTestBase; 7 7 8 8 /** 9 * Tests that language, module and settings.php are applied in the correct 10 * order. 9 * Tests that language, module and settings.php are applied in correct order. - Comment on lines -9 to +9
Our docs standards require the Oxford (serial) comma before "and". They also require not omitting articles like the word "the".
9 * Tests that language, module and settings.php are applied in correct order. 9 * Tests that config overrides are applied in the correct order. 10 * 11 * @todo List what that order should be here; it's not obvious from 12 * scanning the test. Something like: 13 * Overrides should be applied in the following order, from lowest priority 14 * to highest: 15 * - Language overrides 16 * - Module overrides 17 * - settings.php overrides changed this line in version 6 of the diff
- Resolved by quietone
7 7 use Drupal\Core\Test\AssertMailTrait; 8 8 9 9 /** 10 * Tests the email capturing logic, the assertMail assertion and the 11 * drupalGetMails function. 10 * Tests email capturing. - Comment on lines -10 to +10
I don't know what "tests email capturing" means without the current context (or with it for that matter, but even less without it). Could we add at least a little more clarification?
Edited by Jess changed this line in version 6 of the diff
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
- Resolved by quietone
Please register or sign in to reply