Skip to content
Snippets Groups Projects

Issue #3268809: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine'

Closed Issue #3268809: Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine'
Closed quietone requested to merge issue/drupal-3268809:3268809-fix-class-comment into 10.0.x

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • quietone
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • 6 6 use Drupal\KernelTests\KernelTestBase;
    7 7
    8 8 /**
    9 * Tests that language, module and settings.php are applied in the correct
    10 * order.
    9 * Tests that language, module and settings.php are applied in correct order.
    • Comment on lines -9 to +9
      Maintainer

      Our docs standards require the Oxford (serial) comma before "and". They also require not omitting articles like the word "the".

      Suggested change
      9 * Tests that language, module and settings.php are applied in correct order.
      9 * Tests that config overrides are applied in the correct order.
      10 *
      11 * @todo List what that order should be here; it's not obvious from
      12 * scanning the test. Something like:
      13 * Overrides should be applied in the following order, from lowest priority
      14 * to highest:
      15 * - Language overrides
      16 * - Module overrides
      17 * - settings.php overrides
    • quietone changed this line in version 6 of the diff

      changed this line in version 6 of the diff

    • Author Maintainer

      I think that order is correct. I took out the @todo.

    • Please register or sign in to reply
  • Jess
  • 7 7 use Drupal\Core\Test\AssertMailTrait;
    8 8
    9 9 /**
    10 * Tests the email capturing logic, the assertMail assertion and the
    11 * drupalGetMails function.
    10 * Tests email capturing.
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading