Skip to content
Snippets Groups Projects

Issue #3268835: Fix method comments in non tests for Drupal.Commenting.DocComment.ShortSingleLine

Issue #3268835: Fix method comments in non tests for Drupal.Commenting.DocComment.ShortSingleLine
Closed quietone requested to merge issue/drupal-3268835:3268835-fix-method-comments into 10.1.x

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
  • Jess
    Jess @xjm started a thread on the diff
  • 11 11
    12 12 /**
    13 13 * Field handler to provide simple renderer that allows linking to a node.
  • Jess
  • Jess
    Jess @xjm started a thread on the diff
  • 369 369 }
    370 370
    371 371 /**
    372 * Form submission handler for the reindex button on the search admin settings
    373 * form.
    372 * Form submission handler for reindex button on search admin settings form.
    • Comment on lines -372 to +372
      Maintainer

      I almost reworded this since this was another archaic standard, but there are still 44 of these left in core, including on the most important things like EntityFormInterface, so I've left it alone.

    • Author Maintainer

      Why not improve this here? Is it necessary to make a followup?

    • Author Maintainer

      Changed my mind. Yes, let's make a followup and do all those at once.

    • Please register or sign in to reply
  • Jess
  • Jess
  • Jess
  • Jess
    Jess @xjm started a thread on the diff
  • 822 826 }
    823 827
    824 828 /**
    825 * This just returns true. The view argument builder will know where
    826 * to find the argument from.
    829 * This just returns true.
    830 *
    831 * The view argument builder will know where to find the argument from.
    827 832 */
    828 833 protected function defaultDefault() {
    829 834 return TRUE;
  • Jess
  • quietone added 1 commit

    added 1 commit

    • 5e08d14a - Fix 12 comments, the easiest ones.

    Compare with previous version

  • quietone added 1 commit

    added 1 commit

    • 18468a64 - Accepts suggestions for views

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading