Skip to content
Snippets Groups Projects

Issue #2334319 by thenchev, joelpittet, andypost, calebtr, DuaelFr: {% trans...

Open Issue #2334319 by thenchev, joelpittet, andypost, calebtr, DuaelFr: {% trans...
1 unresolved thread
Open Edouard Cunibil requested to merge issue/drupal-2334319:2334319--trans- into 11.x
1 unresolved thread

Issue #2334319 by thenchev, joelpittet, andypost, calebtr, DuaelFr: {% trans %} does not support render array and MarkupInterface valued placeholders

Closes #2334319

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Pott left review comments

    left review comments

  • Alex Pott resolved all threads

    resolved all threads

  • Alex Pott added 1 commit

    added 1 commit

    • e348da63 - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • godotislate added 1 commit

    added 1 commit

    Compare with previous version

  • godotislate added 64 commits

    added 64 commits

    Compare with previous version

  • Adam Bramley added 99 commits

    added 99 commits

    • 48f05716...66097f2a - 90 commits from branch project:11.x
    • 324968af - Issue #2334319 by thenchev, joelpittet, andypost, calebtr, DuaelFr: {% trans...
    • 0d2326f3 - Fix test using old assertIdentical() method.
    • 242ca367 - Bring back change dropped in #86 and fix tests.
    • f509f1b7 - Use an inline template for test instead.
    • c87e4596 - renderVar() returns MarkupInterface object.
    • 35f8c7de - Clean up @todos.
    • ae96cc9f - Apply 2 suggestion(s) to 1 file(s)
    • 7dc31eb3 - Missing semicolon.
    • 9a979136 - Make revisions uncacheable again

    Compare with previous version

  • 193 193 '#template' => '{% trans %}{{ date }} by {{ username }}{% endtrans %}{% if message %}<p class="revision-log">{{ message }}</p>{% endif %}',
    194 194 '#context' => [
    195 195 'date' => $link,
    196 'username' => $this->renderer->renderInIsolation($username),
    196 'username' => $username,
    197 197 'message' => ['#markup' => $revision->revision_log->value, '#allowed_tags' => Xss::getHtmlTagList()],
    198 198 ],
    199 // @todo Fix this properly in https://www.drupal.org/project/drupal/issues/3227637.
    200 '#cache' => [
    201 'max-age' => 0,
    202 ],
    Please register or sign in to reply
    Loading