Skip to content
Snippets Groups Projects

Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL

Open Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL
Open Andor requested to merge issue/drupal-3312049:3312049-return-null-vs-void into 10.1.x
7 files
+ 292
23
Compare changes
  • Side-by-side
  • Inline
Files
7
  • ae4b7247
    Issue #3059955 by oknate, Hardik_Patel_12, paulocs, phenaproxima, seanB,... · ae4b7247
    Lauri Timmanee authored
    Issue #3059955 by oknate, Hardik_Patel_12, paulocs, phenaproxima, seanB, NikolaAt, smustgrave, bnjmnm, yogeshmpawar, rensingh99, xjm, chr.fritsch, lauriii, raman.b, Wim Leers, nikunj.shah, AndySipple, harshitthakore, saurabh.tripathi.cs, AaronMcHale, irene_dobbs, alexpott, andrewmacpherson, dorficus, effulgentsia, himanshu_sindhwani, codersukanta, pankaj.singh, tripurari, snehalgaikwad, priyanka.sahni: It is possible to overflow the number of items allowed in Media Library
@@ -309,6 +309,17 @@
@@ -309,6 +309,17 @@
$('.js-media-library-selected-count').html(selectItemsText);
$('.js-media-library-selected-count').html(selectItemsText);
}
}
 
function checkEnabled() {
 
updateSelectionCount(settings.media_library.selection_remaining);
 
if (
 
currentSelection.length === settings.media_library.selection_remaining
 
) {
 
disableItems($mediaItems.not(':checked'));
 
enableItems($mediaItems.filter(':checked'));
 
} else {
 
enableItems($mediaItems);
 
}
 
}
// Update the selection array and the hidden form field when a media item
// Update the selection array and the hidden form field when a media item
// is selected.
// is selected.
$(once('media-item-change', $mediaItems)).on('change', (e) => {
$(once('media-item-change', $mediaItems)).on('change', (e) => {
@@ -345,7 +356,7 @@
@@ -345,7 +356,7 @@
item.value = currentSelection.join();
item.value = currentSelection.join();
});
});
});
});
checkEnabled();
// The hidden selection form field changes when the selection is updated.
// The hidden selection form field changes when the selection is updated.
$(
$(
once(
once(
@@ -353,17 +364,7 @@
@@ -353,17 +364,7 @@
$form.find('#media-library-modal-selection'),
$form.find('#media-library-modal-selection'),
),
),
).on('change', (e) => {
).on('change', (e) => {
updateSelectionCount(settings.media_library.selection_remaining);
checkEnabled();
// Prevent users from selecting more items than allowed.
if (
currentSelection.length === settings.media_library.selection_remaining
) {
disableItems($mediaItems.not(':checked'));
enableItems($mediaItems.filter(':checked'));
} else {
enableItems($mediaItems);
}
});
});
// Apply the current selection to the media library view. Changing the
// Apply the current selection to the media library view. Changing the
Loading