Skip to content
Snippets Groups Projects

Issue #3309104: Replace REQUEST_TIME in Functional/FunctionalJavascript tests

Open Issue #3309104: Replace REQUEST_TIME in Functional/FunctionalJavascript tests
5 unresolved threads
Open mondrake requested to merge issue/drupal-3309104:3309104-replace-requesttime-in into 10.0.x
5 unresolved threads

Merge request reports

Members who can merge are allowed to add commits.
Merge blocked: 1 check failed

Merge details

  • The source branch is 697 commits behind the target branch.
  • 1 commit will be added to 10.0.x.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
58 58 */
59 59 protected $apcuEnsureUniquePrefix = FALSE;
60 60
61 /**
62 * The test request time.
63 */
64 protected int $testRequestTime;
  • 52 52 $block->setNewRevision(TRUE);
    53 53 $block->setRevisionLogMessage($this->randomMachineName(32));
    54 54 $block->setRevisionUser($this->adminUser);
    55 $block->setRevisionCreationTime(REQUEST_TIME);
    55 $block->setRevisionCreationTime($this->testRequestTime);
  • 70 70 public function testDeterminingChanges() {
    71 71 // Initial creation.
    72 72 $block = $this->createBlockContent('test_changes');
    73 $this->assertEquals(REQUEST_TIME, $block->getChangedTime(), 'Creating a block sets default "changed" timestamp.');
    73 $this->assertEquals($this->testRequestTime, $block->getChangedTime(), 'Creating a block sets default "changed" timestamp.');
  • 97 97 $comment->comment_body->format = 'full_html';
    98 98
    99 99 // Ensure comments are sorted in ascending order.
    100 $time = REQUEST_TIME + ($this->defaultDisplayResults - $i);
    100 $time = $this->testRequestTime + ($this->defaultDisplayResults - $i);
  • 47 47 // Add some test comments, with and without subjects. Because the 10 newest
    48 48 // comments should be shown by the block, we create 11 to test that behavior
    49 49 // below.
    50 $timestamp = REQUEST_TIME;
    50 $timestamp = $this->testRequestTime;
  • Ravi Shankar added 1 commit

    added 1 commit

    • 6f0dded0 - Removed testRequestTime property and used drupal time.

    Compare with previous version

  • Bhanu D added 1 commit

    added 1 commit

    • 5d6c58fd - Replace REQUEST_TIME in Functional/FunctionalJavascript tests.

    Compare with previous version

  • Adam Bramley mentioned in merge request !4317

    mentioned in merge request !4317

  • Please register or sign in to reply
    Loading