Skip to content
Snippets Groups Projects

Issue #3264122: Move all aggregator tests to the module in preperation of removal in d10

Closed Issue #3264122: Move all aggregator tests to the module in preperation of removal in d10
Closed spokje requested to merge issue/drupal-3264122:3264122-move-all-aggregator into 9.4.x

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
22 * A queue instance.
23 *
24 * @var \Drupal\Core\Queue\DatabaseQueue
25 */
26 protected $queue;
27
28 21 /**
29 22 * Modules to enable.
30 23 *
31 24 * @var array
32 25 */
33 protected static $modules = ['system', 'user', 'aggregator'];
26 protected static $modules = ['system', 'user'];
34 27
35 28 /**
36 29 * {@inheritdoc}
  • Comment on lines 18 to 36

    I'm very unsure what this test is supposed to test or has been testing before, but currently it passes without using Queues and aggregator, which seem to leave only a simple form submit test?

    Although it works for this MR, since it doesn't need to use the aggregator module, I think a follow-up issue might be in order to either delete or fix this test?

  • Please register or sign in to reply
  • spokje
    spokje @Spokje started a thread on the diff
  • 20 20 */
    21 21 protected static $modules = [
    22 22 'block',
    23 'aggregator',
  • spokje added 7 commits

    added 7 commits

    • 28196dcf...5f3489ff - 3 commits from branch project:9.4.x
    • e65a2dd8 - Merge branch '9.4.x' into 3264122-move-all-aggregator
    • dbb5cfbb - Split off d6 migrate_ui for aggregator module into its own test
    • 1717a97d - Merge branch '9.4.x' into 3264122-move-all-aggregator
    • af18f5bf - Split off d6 migrate_ui for aggregator module into its own test

    Compare with previous version

  • spokje added 1 commit

    added 1 commit

    • 62d70726 - Split off d6 migrate_drupal_ui for aggregator module into its own test

    Compare with previous version

  • spokje added 3 commits

    added 3 commits

    Compare with previous version

  • spokje added 1 commit

    added 1 commit

    • 667ceece - Split off d7 migrate_drupal_ui for aggregator module into its own test

    Compare with previous version

  • spokje added 1 commit

    added 1 commit

    • 17556e84 - migrate_drupal_ui tests without aggregator module

    Compare with previous version

  • spokje added 3 commits

    added 3 commits

    Compare with previous version

  • spokje added 12 commits

    added 12 commits

    • 7c70a6e6...a2c7e7b0 - 8 commits from branch project:9.4.x
    • 86578bea - Merge branch '9.4.x' into 3264122-move-all-aggregator
    • 4d71cc3c - Merge branch '9.4.x' into 3264122-move-all-aggregator
    • c832dbf0 - Merge branch '9.4.x' into 3264122-move-all-aggregator
    • 092fccff - Split off d6 migrate_drupal_ui IdConflictTest for aggregator module into its own test

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading