Skip to content
Snippets Groups Projects

Issue #2715089: Document the type of tables an entity type can define

Open Issue #2715089: Document the type of tables an entity type can define
4 unresolved threads
Open Ahmet Burkan requested to merge issue/drupal-2715089:2715089-document-type-table into 11.x
4 unresolved threads

Drupal issue link: 2715089

Edited by Ahmet Burkan

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
115 115 /**
116 116 * The name of the entity type's base table.
117 117 *
118 * The base table is used to store single cardinality, untranslatable base
119 * fields such as the UUID or ID.
120 *
  • Comment on lines +118 to +120

    In Node.php, the base table for node is "node" and that table contains nid, vid, type, uuid and langcode. That does not match this description.

    Am I missing something?

  • We should mention this table has the bundle.

    I'm not sure what the langcode column does here, since the langcode is obviously translatable.

    The revision ID here is -- I assume -- the revision ID of the current revision. That should me mentioned too.

  • Please register or sign in to reply
  • quietone
    quietone @quietone started a thread on the diff
  • 122 125 /**
    123 126 * The name of the entity type's revision data table.
    124 127 *
    128 * The revision data table is required for translatable entity types if the
    129 * entity type also supports revisions. The revision data table stores
    130 * base field revision data per language for revisionable fields.
    131 *
    • Comment on lines +128 to +131

      This needs to be wrapped correctly.

      I think the sentences should be swapped, that is explain what the table is then add details of when it is needed. Something like this

      "The revision data table stores the revision data for each base field that supports revisions per language. The table is required for translatable entity types that support revisions."

    • Please register or sign in to reply
  • quietone
    quietone @quietone started a thread on the diff
  • 129 136 /**
    130 137 * The name of the entity type's revision table.
    131 138 *
    139 * The revision table stores basic entity key revisions and revision metadata.
    140 *
  • quietone
    quietone @quietone started a thread on the diff
  • 136 145 /**
    137 146 * The name of the entity type's data table.
    138 147 *
    148 * The data table is required for translatable entity types. The data table
    149 * stores base field data per language.
    150 *
    • Comment on lines +148 to +150

      Like before, I think the table should be described first then details of where it is needed.

      Should this expand on what 'base field data' is? Without more information the current second sentence isn't adding any more information.

      Do we need to add where the non base field data is stored?

    • Please register or sign in to reply
  • quietone added 4531 commits

    added 4531 commits

    Compare with previous version

  • quietone changed target branch from 9.4.x to 11.x

    changed target branch from 9.4.x to 11.x

  • Please register or sign in to reply
    Loading