Skip to content
Snippets Groups Projects

Issue #3205909: Ensure only needed permission are used for Update module functional tests

Open Issue #3205909: Ensure only needed permission are used for Update module functional tests
issue/drupal-3205909:3205909-ensure-only-needed into 9.3.x
1 unresolved thread
Open Kunal Sachdev requested to merge issue/drupal-3205909:3205909-ensure-only-needed into 9.3.x
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/update/tests/src/Functional/UpdateSemverTestBase.php
42 42 $admin_user = $this->drupalCreateUser([
43 43 'administer site configuration',
44 44 'administer modules',
45 'administer themes',
  • Adam G-H
    Adam G-H @phenaproxima
    Developer

    In UpdateSemverTestBase::setUp(), we grant the administer modules permission to $admin_user. It turns out that this permission is needed by only one test case (\Drupal\Tests\update\Functional\UpdateSemverCoreTest::testModulePageRegularUpdate()), so I would suggest we remove the administer modules permission from here, and change that test to explicitly log in a user with the administer site configuration and administer modules permissions.

  • Ted Bowman
    Ted Bowman @tedbow
    Developer

    good catch. fixed

  • Please register or sign in to reply
  • Ted Bowman added 1 commit

    added 1 commit

    • ff319f57 - remove 'administer modules' except in the 1 needed method

    Compare with previous version

    • Please register or sign in to reply