Issue #3521884: tableresponsive.js causes huge page load time for extensions page
2 unresolved threads
Signed-off-by: Nigel Cunningham nigel@nigelcunningham.com.au
Closes #3521884
Merge request reports
Activity
4 4 */ 5 5 6 6 (function ($, Drupal, window) { 7 8 let disableVisibilityReevaluation; changed this line in version 5 of the diff
added 1 commit
- 3b79ec71 - Add comment describing purpose to disableVisibilityReevaluation var.
added 8 commits
-
3b79ec71...1b74d431 - 5 commits from branch
project:11.x - 16aa55f5 - Issue #3521884: tableresponsive.js causes huge page load time for extensions page
- 1dc713c8 - Apply lint fixes.
- c2607d77 - Add comment describing purpose to disableVisibilityReevaluation var.
Toggle commit list-
3b79ec71...1b74d431 - 5 commits from branch
69 TableResponsive.tables.push(new TableResponsive(table)); 70 }, 71 const tables = once( 72 'tableresponsive', 73 'table.responsive-enabled', 74 context, 71 75 ); 76 disableVisibilityReevaluation = true; 77 let count = 0; 78 tables.forEach((table) => { 79 count++; 80 if (count === tables.length) { 81 disableVisibilityReevaluation = false; 82 } 83 TableResponsive.tables.push(new TableResponsive(table)); 84 }); -
I would rather fix the event listener instead of going around like this.
the trigger(resize) should be out of the constructor and that will solve the problems of too many calls to that function. needs to be added to the attach behavior instead
Edited by Théodore Biadala changed this line in version 5 of the diff
added 1 commit
- 8c445f3f - trigger resize from the behavior, not the constructor
Please register or sign in to reply