Skip to content
Snippets Groups Projects

Resolve #3521059 "Finish deprecating 'Update Manager' related code in Update Status"

Closed Resolve #3521059 "Finish deprecating 'Update Manager' related code in Update Status"
issue/drupal-3521059:3521059-finish-deprecating-update-manager into 11.x
Closed Derek Wright requested to merge issue/drupal-3521059:3521059-finish-deprecating-update-manager into 11.x

Closes #3521059

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • nicxvan
  • nicxvan
  • nicxvan
  • nicxvan
    nicxvan @nicxvan started a thread on the diff
    • core/modules/update/tests/src/Functional/UpdateManagerTest.php 0 → 100644
    8 * Tests legacy Update Manager functionality of the Update Status module.
    9 *
    10 * @group legacy
    11 * @group update
    12 */
    13 class UpdateManagerTest extends UpdateTestBase {
    14
    15 /**
    16 * {@inheritdoc}
    17 */
    18 protected $defaultTheme = 'stark';
    19
    20 /**
    21 * Checks that clearing the disk cache works.
    22 */
    23 public function testClearDiskCache(): void {
    • nicxvan
      nicxvan @nicxvan

      I won't quibble about this being moved, but you can add the @group legacy to the comment on the test where it was.

    • Derek Wright
      Derek Wright @dww
      Author Developer

      Good to know. I was thinking moving it into this separate test class would make it easier to completely remove in D12. But it could go either way. Leaving this thread open for other input.

    • Please register or sign in to reply
  • Derek Wright added 1 commit

    added 1 commit

    • da047a93 - [#3521059]: Apply suggestions to use __FUNCTION__ not __METHOD__ (since...

    Compare with previous version

  • Derek Wright left review comments

    left review comments

  • Derek Wright added 17 commits

    added 17 commits

    • da047a93...87c85acb - 7 commits from branch project:11.x
    • 37ddb468 - [#3521059]: Deprecate 'update.root' service and the src/UpdateRoot.php class
    • 067becce - [#3521059]: Deprecate more procedural functions in update.module
    • 8afec9d6 - Mark Kernel/UpdateDeleteFileIfStaleTest.php as a legacy test
    • 5b60b90c - Add calls to deprecated code from deprecated code into .phpstan-baseline.php for now
    • 95abce34 - Move testClearDiskCache() from UpdateMiscTest to a new UpdateManagerTest that...
    • d22acdd5 - Add defaultTheme to UpdateManagerTest
    • eb96e022 - [#3521059] Clarify comment at top of UpdateRoot.php
    • 609715a0 - Revert "Add calls to deprecated code from deprecated code into .phpstan-baseline.php for now"
    • b1e1b1dd - [#3521059]: Use @phpstan-ignore instead of updating the baseline for calls to...
    • 7ccc86d1 - [#3521059]: Apply suggestions to use __FUNCTION__ not __METHOD__ (since...

    Compare with previous version

    Toggle commit list
  • Derek Wright added 1 commit

    added 1 commit

    • 4c3946ba - [#3521059]: Stop calling update_clear_update_disk_cache() from hook_cron

    Compare with previous version

  • Derek Wright added 37 commits

    added 37 commits

    • 4c3946ba...6810f24a - 24 commits from branch project:11.x
    • 6810f24a...3ac13890 - 3 earlier commits
    • dc57dbae - Add calls to deprecated code from deprecated code into .phpstan-baseline.php for now
    • f8378d16 - Move testClearDiskCache() from UpdateMiscTest to a new UpdateManagerTest that...
    • fb4e338e - Add defaultTheme to UpdateManagerTest
    • cbe7667b - [#3521059] Clarify comment at top of UpdateRoot.php
    • af4b396b - Revert "Add calls to deprecated code from deprecated code into .phpstan-baseline.php for now"
    • ce94f238 - [#3521059]: Use @phpstan-ignore instead of updating the baseline for calls to...
    • 2d74ad98 - [#3521059]: Apply suggestions to use __FUNCTION__ not __METHOD__ (since...
    • a7f3d35a - [#3521059]: Stop calling update_clear_update_disk_cache() from hook_cron
    • 5d894c51 - [#3521059]: Deprecate the 'authorize-report' template and template_preprocess_authorize_report()
    • 34f422f9 - [#3521059]: Add @deprecated comments to authorize-report.html.twig (both from system and stable9)

    Compare with previous version

    Toggle commit list
  • Derek Wright added 2 commits

    added 2 commits

    Compare with previous version

  • Derek Wright added 1 commit

    added 1 commit

    Compare with previous version

  • Derek Wright added 1 commit

    added 1 commit

    • f67afd40 - [#3521059]: Fix update_post_update_clear_disk_cache() to not rely on any deprecated code

    Compare with previous version

  • Derek Wright added 2 commits

    added 2 commits

    • 8c69b379 - [#3521059]: Remove 'allow_authorize_operations' from default.settings.php
    • b7052b53 - [#3521059]: Deprecate the 'allow_authorize_operations' setting

    Compare with previous version

  • Derek Wright added 1 commit

    added 1 commit

    • b419b3d0 - Revert "[#3521059]: Deprecate the 'allow_authorize_operations' setting"

    Compare with previous version

  • Derek Wright added 1 commit

    added 1 commit

    • c9452f82 - [#3521059]: Add trigger_error() to deprecation for _update_manager_unique_identifier()

    Compare with previous version

  • Derek Wright added 1 commit

    added 1 commit

    • 2595d9f0 - [#3521059]: Looks like phpstan doesn't notice the deprecated call inside a...

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply