Skip to content
Snippets Groups Projects

Rebase to 11.x

Open Thijs Boots requested to merge issue/drupal-3130197:3130197-faulty-toolbar-11.x into 11.x
2 files
+ 10
5
Compare changes
  • Side-by-side
  • Inline
Files
2
@@ -31,13 +31,19 @@ public function __construct(
/**
* Returns an AJAX response to render the toolbar subtrees.
*
* @param string $hash
* The hash of the toolbar subtrees to validate.
*
* @return \Drupal\Core\Ajax\AjaxResponse
* The AJAX response containing the rendered toolbar subtrees.
*/
public function subtreesAjax() {
public function subtreesAjax(string $hash) {
[$subtrees] = toolbar_get_rendered_subtrees();
$expected_hash = _toolbar_get_subtrees_hash()[0];
$response = new AjaxResponse();
$response->addCommand(new SetSubtreesCommand($subtrees));
if (hash_equals($expected_hash, $hash)) {
$response->addCommand(new SetSubtreesCommand($subtrees));
}
// The Expires HTTP header is the heart of the client-side HTTP caching. The
// additional server-side page cache only takes effect when the client
@@ -64,8 +70,7 @@ public function subtreesAjax() {
* The access result.
*/
public function checkSubTreeAccess($hash) {
$expected_hash = _toolbar_get_subtrees_hash()[0];
return AccessResult::allowedIf($this->currentUser()->hasPermission('access toolbar') && hash_equals($expected_hash, $hash))->cachePerPermissions();
return AccessResult::allowedIf($this->currentUser()->hasPermission('access toolbar'))->cachePerPermissions();
}
/**
Loading