enable for tests in modules (!11732) · Merge requests · project / drupal · GitLab

Snippets Groups Projects

Open quietone requested to merge issue/drupal-3517369:3517369-fix-drupal.commenting.functioncomment.missing-in into 11.x 2 months ago

1 unresolved thread

Closes #3517369

Activity

quietone added 6 commits 2 months ago
added 6 commits

75ee212c...711e9ad4 - 4 commits from branch project:11.x

a1fc6323 - enable for tests in modules

ed5964ca - more fixes

Compare with previous version
quietone @quietone started a thread on the diff 2 months ago

core/modules/system/tests/modules/router_test_directory/src/TestControllers.php

19	19
20	20	const LONG_TEXT = 'This is text long enough to trigger Apache mod_deflate to add a `vary: accept-encoding` header to the response.';
21	21
	22	// phpcs:disable Drupal.Commenting.FunctionComment.Missing
quietone @quietone 2 months ago Author Maintainer Many methods in the class are named like 'testN', which makes it difficult to know what it being tested. I think a better use of time is to ignore this sniff in this file as needed. A followup could be made to improve the comments, if we think that is worthwhile. Please register or sign in to reply

quietone left review comments 2 months ago

left review comments

Please register or sign in to reply