low hanging fruit

Closes #3513596

It was more readable before I think

It may be more readable but it still needs a period at the end to be a valid sentence.

If the period is added it becomes : ? * < > " ' / \. And with that Jonathan Smith found it confusing on a similar change in JsonTest.php ( see !505 (comment 477852)). That is why I added the quotes around each character.

changed this line in version 6 of the diff

Thanks for un-doing this change. This thread can be resolved now.

In fact the original change altered the order of the quotes. The existing committed code has double quote " followed by single quote ' which matches the order in the preg_match. So it would be good to revert this unnecessary change totally. Here is what the MR currently has:

Thank you. Done. This thread can be closed.

I can't close this thread, but there is nothing more to do here, and it can be resolved.

Didn't review all of it. In general I find wrapping code examples in quotes to make comments less readable. But I left a comment of at least one place where the punctuation is not at the end of the sentence.

added 1 commit

• 5b318047 - respond to feedback

Compare with previous version

added 7 commits

• 5b318047...b112cf53 - 5 commits from branch project:11.x
• 4d949a93 - low hanging fruit
• fd8cd61d - respond to feedback

Compare with previous version

added 1 commit

• 48b02440 - remove semi-colon

Compare with previous version

added 31 commits

• 48b02440...17a05cf2 - 27 commits from branch project:11.x
• b0c0bf29 - low hanging fruit
• f28338a4 - respond to feedback
• 922869f7 - remove semi-colon
• f6027875 - MachineNameTransliterationTest

Compare with previous version

added 30 commits

• f6027875...a0a7640c - 25 commits from branch project:11.x
• b5160a0c - low hanging fruit
• 9a70ef0a - respond to feedback
• 44144db9 - remove semi-colon
• 78221662 - MachineNameTransliterationTest
• 5660ab0b - revert ConfigBase.php

Compare with previous version

assigned to @quietone

unassigned @quietone

added 1 commit

• b48d048e - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 107 commits

• b48d048e...bf98f857 - 102 commits from branch project:11.x
• 1dc60a23 - low hanging fruit
• 08ea62e5 - respond to feedback
• f9f5b965 - remove semi-colon
• 52265220 - MachineNameTransliterationTest
• 90b8430d - revert ConfigBase.php

Compare with previous version

added 9 commits

• 90b8430d...1a2079a4 - 4 commits from branch project:11.x
• 65887309 - low hanging fruit
• af010c61 - respond to feedback
• a7c618c0 - remove semi-colon
• fd358729 - MachineNameTransliterationTest
• 789a65d7 - revert ConfigBase.php

Compare with previous version

added 75 commits

• 789a65d7...b3238209 - 70 commits from branch project:11.x
• 4306166b - low hanging fruit
• 7df566d6 - respond to feedback
• e0e24aec - remove semi-colon
• c45fcaef - MachineNameTransliterationTest
• 3c4e5da2 - revert ConfigBase.php

Compare with previous version

added 36 commits

• 3c4e5da2...bedda6ac - 30 commits from branch project:11.x
• 776d5a5c - low hanging fruit
• 678cd4a8 - respond to feedback
• 9d193967 - remove semi-colon
• 76690311 - MachineNameTransliterationTest
• ad098b2d - revert ConfigBase.php
• ec4a27ae - ThemeSettingsForm

Compare with previous version

added 113 commits

• ec4a27ae...73932ca6 - 107 commits from branch project:11.x
• c035dfba - low hanging fruit
• 98308a14 - respond to feedback
• 31ae6e9c - remove semi-colon
• 20eb3243 - MachineNameTransliterationTest
• 69f7f491 - revert ConfigBase.php
• 040ea411 - ThemeSettingsForm

Compare with previous version