Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
drupal
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
drupal
Merge requests
!11462
Don't load individual placeholders from cache
Code
Review changes
Check out branch
Download
Patches
Plain diff
Closed
Don't load individual placeholders from cache
issue/drupal-3512762:3512762-optimize-placeholder-retrieval
into
11.x
Overview
0
Commits
4
Pipelines
17
Changes
5
Closed
Kristiaan Van den Eynde
requested to merge
issue/drupal-3512762:3512762-optimize-placeholder-retrieval
into
11.x
3 months ago
Overview
0
Commits
4
Pipelines
17
Changes
5
Expand
Closes
#3512762
0
0
Merge request reports
Compare
11.x
version 16
e06778ca
2 months ago
version 15
07824f58
2 months ago
version 14
4c8546ff
2 months ago
version 13
bf51e3db
2 months ago
version 12
d2d33fe6
2 months ago
version 11
f0d6450f
2 months ago
version 10
7a1c10da
2 months ago
version 9
13a59cd8
2 months ago
version 8
53d54a1b
2 months ago
version 7
91027d1d
2 months ago
version 6
28b158da
2 months ago
version 5
a5decd3d
2 months ago
version 4
8118d623
2 months ago
version 3
8d92c709
3 months ago
version 2
341223ce
3 months ago
version 1
f8d24ee6
3 months ago
11.x (base)
and
latest version
latest version
9b89758b
4 commits,
2 months ago
version 16
e06778ca
3 commits,
2 months ago
version 15
07824f58
3 commits,
2 months ago
version 14
4c8546ff
2 commits,
2 months ago
version 13
bf51e3db
3 commits,
2 months ago
version 12
d2d33fe6
2 commits,
2 months ago
version 11
f0d6450f
11 commits,
2 months ago
version 10
7a1c10da
12 commits,
2 months ago
version 9
13a59cd8
10 commits,
2 months ago
version 8
53d54a1b
8 commits,
2 months ago
version 7
91027d1d
7 commits,
2 months ago
version 6
28b158da
6 commits,
2 months ago
version 5
a5decd3d
5 commits,
2 months ago
version 4
8118d623
4 commits,
2 months ago
version 3
8d92c709
3 commits,
3 months ago
version 2
341223ce
2 commits,
3 months ago
version 1
f8d24ee6
1 commit,
3 months ago
5 files
+
77
−
60
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
5
Search (e.g. *.vue) (Ctrl+P)
core/lib/Drupal/Core/Render/Renderer.php
+
8
−
1
Options
@@ -276,7 +276,14 @@ protected function doRender(&$elements, $is_root_call = FALSE) {
// Try to fetch the prerendered element from cache, replace any placeholders
// and return the final markup.
if
(
isset
(
$elements
[
'#cache'
][
'keys'
]))
{
//
// If the element was set to create a placeholder, we do not try to load it
// from the cache, as \Drupal\Core\Render\Placeholder\CachedStrategy has an
// optimization to load them all in one go, rather than individually here.
// If the current request method is not cacheable, no placeholders are
// generated, in that case, it's still better to fetch render cached
// elements individually instead of fully building them again.
if
(
isset
(
$elements
[
'#cache'
][
'keys'
])
&&
(
empty
(
$elements
[
'#create_placeholder'
])
||
!
$this
->
requestStack
->
getCurrentRequest
()
->
isMethodCacheable
()))
{
$cached_element
=
$this
->
renderCache
->
get
(
$elements
);
if
(
$cached_element
!==
FALSE
)
{
$elements
=
$cached_element
;
Loading