Issue #2699565: Replace \Drupal:: with $this->container->get() in test classes of Basic Auth module

core/modules/basic_auth/tests/modules/basic_auth_test/src/BasicAuthTestController.php

@@ -4,16 +4,32 @@
 
 namespace Drupal\basic_auth_test;
 
+use Drupal\Core\PageCache\ResponsePolicyInterface;
+use Drupal\Core\State\StateInterface;
+
 /**
  * Provides routes for HTTP Basic Authentication testing.
  */
 class BasicAuthTestController {
 
+  /**
+   * Constructs a new BasicAuthTestController object.
+   *
+   * @param \Drupal\Core\State\StateInterface $state
+   *   The state storage service.
+   * @param \Drupal\Core\PageCache\ResponsePolicy\ResponsePolicyInterface $pageCacheKillSwitch
+   *   The page cache kill switch service.
+   */
+  public function __construct(
+    private StateInterface $state,
+    private ResponsePolicyInterface $pageCacheKillSwitch,
+  ) {}
+
   /**
    * @see \Drupal\basic_auth\Tests\Authentication\BasicAuthTest::testControllerNotCalledBeforeAuth()
    */
   public function modifyState() {
-    \Drupal::state()->set('basic_auth_test.state.controller_executed', TRUE);
+    $this->state->set('basic_auth_test.state.controller_executed', TRUE);
     return ['#markup' => 'Done'];
   }
 
@@ -22,10 +38,10 @@ public function modifyState() {
    */
   public function readState() {
     // Mark this page as being uncacheable.
-    \Drupal::service('page_cache_kill_switch')->trigger();
+    $this->pageCacheKillSwitch->trigger();
 
     return [
-      '#markup' => \Drupal::state()->get('basic_auth_test.state.controller_executed') ? 'yep' : 'nope',
+      '#markup' => $this->state->get('basic_auth_test.state.controller_executed') ? 'yep' : 'nope',
       '#cache' => [
         'max-age' => 0,
       ],

[Alex Pott]

-  /**
-   * Constructs a new BasicAuthTestController object.
-   *
-   * @param \Drupal\Core\State\StateInterface $state
-   *   The state storage service.
-   * @param \Drupal\Core\PageCache\ResponsePolicy\ResponsePolicyInterface $pageCacheKillSwitch
-   *   The page cache kill switch service.
-   */

Constructor documentation is no longer necessary.