Draft: Resolve #3485896 "Donquixote suggested changes part2"

Same as issue/drupal-3485896!7

Pipeline failed in the fork.

marked this merge request as draft

added 2 commits

• 65920f89 - Calculate $legacyImplementationMap later, in registerImplementations().
• 1f506407 - Rename some variables in foreach().

Compare with previous version

added 5 commits

• adb66800 - Change how empty arrays are removed.
• e8f6b21c - Rename $legacyImplementationMap -> $moduleImplementsMap.
• fee379f9 - Rename $method_hooks -> $methods.
• 191f13fb - Calculate $tagsInfoByClass before writing to the container.
• 7c13784d - Add line breaks, convert arrow function to regular closure.

Compare with previous version

added 196 commits

• 7c13784d...0c430949 - 35 commits from branch project:11.x
• 0c430949...cc7a591e - 151 earlier commits
• e4c6bfdc - Collapse HookPriority::set() into HookCollectorPass::registerImplementations().
• cf8be043 - Do not unset the entry in $implementations, because no reason to.
• 230b177b - Initialize $map before foreach().
• f3d7b405 - Calculate $map and $tagsInfoByClass in separate foreach().
• 34fc70ba - Collapse registerComplexHookImplementations() into registerImplementations().
• e1e47eee - fixup! Collapse HookPriority::set() into HookCollectorPass::registerImplementations().
• bdf73c9c - Collapse addTagToDefinition() into registerImplementations().
• 5438afbd - fixup! Collapse HookPriority::set() into HookCollectorPass::registerImplementations().
• 7059494a - Rewrite parts of HookCollectorPass to calculate first, then write to container.
• af51ab5b - More elegant array merge in ModuleHandler.

Compare with previous version

added 208 commits

• af51ab5b...93ec7a93 - 45 commits from branch project:11.x
• 93ec7a93...181b3358 - 153 earlier commits
• 18122444 - Calculate $otherSpecifiers later.
• ee8734e3 - Collapse HookPriority::change() into HookCollectorPass::registerImplementations().
• 6afac68d - Collapse HookPriority::set() into HookCollectorPass::registerImplementations().
• 0eb939fd - Do not unset the entry in $implementations, because no reason to.
• 1f52dd54 - Initialize $map before foreach().
• a1be6f42 - Calculate $map and $tagsInfoByClass in separate foreach().
• 733722d0 - Collapse registerComplexHookImplementations() into registerImplementations().
• 26e1a2b4 - Collapse addTagToDefinition() into registerImplementations().
• 469a15f3 - Rewrite parts of HookCollectorPass to calculate first, then write to container.
• 36073c4e - More elegant array merge in ModuleHandler.

Compare with previous version

added 14 commits

• 36073c4e...c31f6bab - 4 earlier commits
• 006f255a - Calculate $map and $tagsInfoByClass in separate foreach().
• fc2cd09c - Collapse registerComplexHookImplementations() into registerImplementations().
• 3a9a7bb6 - Collapse addTagToDefinition() into registerImplementations().
• 68068672 - Rewrite parts of HookCollectorPass to calculate first, then write to container.
• a4321e41 - More elegant array merge in ModuleHandler.
• 024df078 - Collect different attribute types separately.
• fb3c6785 - Extract getOrderExtraTypes from ::process().
• 12e6fa69 - Collapse registerImplementations() into ::process().
• daa7b723 - Don't use the nested array $implementations for calculations.
• a15f37f7 - Don't call ->process() from ->getImplementations().

Compare with previous version

added 14 commits

• a15f37f7...fa408558 - 4 earlier commits
• eaa138c1 - Calculate $map and $tagsInfoByClass in separate foreach().
• 714bf2cf - Collapse registerComplexHookImplementations() into registerImplementations().
• a59d7646 - Collapse addTagToDefinition() into registerImplementations().
• ca3680d2 - Rewrite parts of HookCollectorPass to calculate first, then write to container.
• 83f0ab0c - More elegant array merge in ModuleHandler.
• 0d524878 - Collect different attribute types separately.
• 722d51cf - Extract getOrderExtraTypes from ::process().
• 65366f1a - Collapse registerImplementations() into ::process().
• f7cb2500 - Don't use the nested array $implementations for calculations.
• dc9830f4 - Don't call ->process() from ->getImplementations().

Compare with previous version

added 3 commits

• 7cfacabb - No need to set container.modules anymore.
• 31f21274 - Don't use the container to get a reflection class.
• 3da92f6f - Don't create a collector in the collector.

Compare with previous version

added 2 commits

• 6406c20a - Array type docs on HookCollectorPass::getImplementations().
• 81bf66f4 - Don't pass collectors and containers around.

Compare with previous version