enable and fix for Unit tests
Closes #3508506
Merge request reports
Activity
42 42 $big_pipe_response_attachments_processor->processAttachments($non_html_response); 43 43 } 44 44 45 /** 46 * Provides data to testNonHtmlResponse(). 47 */ 45 48 public static function nonHtmlResponseProvider() { - Comment on lines +45 to 48
This pattern (provides data to ...) is one that we have several times in this issue. I'm not a big fan of that, since using the same data provider in another test-method (or naming that) will now have to lead to an update of the docs here.
Is there a way we can document it in another way, or maybe relax the requirement for data providers?
@borisson_ , I agree that can be a problem. I don't know of better text for these so I am using what I have seen most often and what I use myself. Fortunately, in my wanderings through core I have found that using one data provider for multiple test methods is not common, even rare. So, this shouldn't cause a significant amount of future work.
Relaxing the rule for a method comment on a data provider seems sensible. And we can discuss that in the Coding Standards project. There are already quite a few issues in the Coding Standards project about tests. All of them are in need of triage. Here are some of them;
added 106 commits
-
4c9d5520...8610d622 - 104 commits from branch
project:11.x - 969dcf39 - enable and fix for Unit tests
- c7d69a4e - TestSqlIdMap.php
-
4c9d5520...8610d622 - 104 commits from branch
added 42 commits
-
c7d69a4e...96df9ddb - 40 commits from branch
project:11.x - 2f589d62 - enable and fix for Unit tests
- 4bb1e165 - TestSqlIdMap.php
-
c7d69a4e...96df9ddb - 40 commits from branch
