Resolve #3506444 "Preprocess username caching"

Closes #3506444

added 1 commit

• 30cb18c7 - Create new "view linked label" entity and update tests.

Compare with previous version

added 1 commit

• 0e8941fc - Fix test.

Compare with previous version

added 1 commit

• 2a5e1543 - Use different logic in test.

Compare with previous version

marked this merge request as ready

Should not we just re-use "view label"? OR also add "view label" operation to this "exception list"? Because if I am not mistaken (and as far as I remember) the same issue exists on user lists that includes my username when I am viewing the list.

Viewing labels is not what's causing the problem here. It's that some labels can have a link to the entity they represent. That's where the access check comes in and where we really shouldn't be varying by user as the end result would be inconsistent anyway.

The 'view label' operation always returns TRUE for users. But we can't use that because the 'username' theme hook tries to add in links in template_preprocess_username().

If we could differentiate between where we want a linked username and where we simply want a username, we could switch between using 'view label' and 'view linked label' accordingly.

added 312 commits

• 2a5e1543...2be93630 - 307 commits from branch project:11.x
• a648b731 - Issue #3506444: Handle cacheability in template_preprocess_username().
• 4ae07305 - Add test.
• 702e39c2 - Create new "view linked label" entity and update tests.
• 79f2a2c4 - Fix test.
• 17da729a - Use different logic in test.

Compare with previous version