Skip to content
Snippets Groups Projects

Issue #3504272 by mogtofu33, goz: IconFinder does not generate proper url with base_path()

Open Issue #3504272 by mogtofu33, goz: IconFinder does not generate proper url with base_path()
issue/drupal-3504272:3504272-iconfinder-invalid-url-generated into 11.x
3 unresolved threads
Open Jean Valverde requested to merge issue/drupal-3504272:3504272-iconfinder-invalid-url-generated into 11.x
3 unresolved threads

Closes #3504272

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/lib/Drupal/Core/Theme/Icon/IconFinder.php
297 297 $has_icon_pattern = \str_contains($path_info_filename, self::ICON_ID_PATTERN);
298 298
299 299 foreach ($finder as $file) {
300 /** @var SplFileInfo $file */
  • Stephen Mustgrave
    Stephen Mustgrave @smustgrave started a thread on the diff
    • core/lib/Drupal/Core/Theme/Icon/IconFinder.php
    297 297 $has_icon_pattern = \str_contains($path_info_filename, self::ICON_ID_PATTERN);
    298 298
    299 299 foreach ($finder as $file) {
    300 /** @var SplFileInfo $file */
    300 301 $file_absolute_path = $file->getPathName();
    302 /** @var \Symfony\Component\Finder\SplFileInfo $file */
  • Stephen Mustgrave
    Stephen Mustgrave @smustgrave started a thread on an old version of the diff
    • core/tests/Drupal/Tests/Core/Theme/Icon/IconFinderTest.php
    852 851 }
    853 852
    854 853 }
    854
    855 // @todo Remove as part of https://www.example.com/node/2529170.
  • Jean Valverde added 1 commit

    added 1 commit

    Compare with previous version

  • Pierre Dureau added 488 commits

    added 488 commits

    • c70757ef...4815dccf - 481 commits from branch project:11.x
    • 78ea6372 - Issue #3504272 by mogtofu33, goz: IconFinder does not generate proper url with base_path()
    • 14287c8c - Issue #3504272 by mogtofu33, goz: IconFinder does not generate proper url with base_path()
    • e09d093c - style: fix some missing comma and return type
    • b735d9d9 - fix: back to simple remove starting slash, update test
    • 8f9691e6 - style: fix styling
    • 2e6a38ce - tests: add tearDown to avoid any side effect
    • 5363d154 - doc: wrong issue url domain

    Compare with previous version

    Toggle commit list
    • Please register or sign in to reply