Deprecate magic ServiceProvider file discovery; declare in services.yml
Closes #2910814
Merge request reports
Activity
476 476 throw new InvalidArgumentException(sprintf('The service file "%s" is not valid. It should contain an array. Check your YAML syntax.', $file)); 477 477 } 478 478 479 if ($invalid_keys = array_keys(array_diff_key($content, ['parameters' => 1, 'services' => 1]))) { 479 if ($invalid_keys = array_keys(array_diff_key($content, array('parameters' => 1, 'services' => 1, 'service_providers' => 1)))) { -
Why this change?
Edited by nicxvan 
Do you mean the array()? That's because the patch was oooooold.
Edited by Joachim Noreikochanged this line in version 2 of the diff
1 <?php 2 3 namespace Drupal\drupalkernel_module_service_providers; -
This module needs to be renamed drupal_kernel_... for code spelling.
Class names and files need updating too to DrupalKernel
Edited by nicxvan changed this line in version 5 of the diff
1 <?php 2 3 namespace Drupal\drupalkernel_module_service_providers; 4 5 use Drupal\Core\DependencyInjection\ContainerBuilder; 6 use Drupal\Core\DependencyInjection\ServiceProviderInterface; 7 8 class DrupalkernelModuleServiceProvidersServiceProvider implements ServiceProviderInterface { 9 10 /** 11 * {@inheritdoc} 12 */ 13 public function register(ContainerBuilder $container) { changed this line in version 4 of the diff
1 <?php 2 3 namespace Drupal\drupalkernel_module_service_providers; 4 5 use Drupal\Core\DependencyInjection\ContainerBuilder; 6 use Drupal\Core\DependencyInjection\ServiceProviderInterface; 7 8 class DrupalkernelModuleServiceProvidersServiceProvider2 implements ServiceProviderInterface { 9 10 /** 11 * {@inheritdoc} 12 */ 13 public function register(ContainerBuilder $container) { changed this line in version 4 of the diff
11 * @group DrupalKernel 12 * @group legacy 13 */ 14 class ImplicitServiceProvidersDeprecationTest extends KernelTestBase { 15 16 /** 17 * {@inheritdoc} 18 */ 19 protected static $modules = ['drupalkernel_module_service_providers']; 20 21 /** 22 * Tests the deprecation of implicit service providers. 23 * 24 * @expectedDeprecation Implicit service providers are deprecated in Drupal 8.7.x and will be removed before Drupal 9.0.0. Instead declare your drupalkernel_module_service_providers module service provider class Drupal\drupalkernel_module_service_providers\DrupalkernelModuleServiceProvidersServiceProvider in drupalkernel_module_service_providers.services.yml file. See https://www.drupal.org/node/2974194. 25 */ 26 public function testDeprecation() { changed this line in version 4 of the diff
9 * Tests the deprecation of implicit service providers. 10 * 11 * @group DrupalKernel 12 * @group legacy 13 */ 14 class ImplicitServiceProvidersDeprecationTest extends KernelTestBase { 15 16 /** 17 * {@inheritdoc} 18 */ 19 protected static $modules = ['drupalkernel_module_service_providers']; 20 21 /** 22 * Tests the deprecation of implicit service providers. 23 * 24 * @expectedDeprecation Implicit service providers are deprecated in Drupal 8.7.x and will be removed before Drupal 9.0.0. Instead declare your drupalkernel_module_service_providers module service provider class Drupal\drupalkernel_module_service_providers\DrupalkernelModuleServiceProvidersServiceProvider in drupalkernel_module_service_providers.services.yml file. See https://www.drupal.org/node/2974194. -
This format is not correct:
The trigger_error message 'Implicit service providers are | | deprecated in Drupal 8.7.x and will be removed before Drupal | | 9.0.0. Instead declare your $module module service provider | | class $class in $module.services.yml file. See | | https://www.drupal.org/node/2974194.' does not match the relaxed | | standard format: %thing% is deprecated in %deprecation-version% | | any free text %removal-version%. %extra-info%. See %cr-link% | | (Drupal.Semantics.FunctionTriggerError.TriggerErrorTextLayoutRelaxed)
changed this line in version 5 of the diff
1 <?php 2 changed this line in version 5 of the diff
1 <?php 2 changed this line in version 5 of the diff
1 <?php 2 changed this line in version 5 of the diff
661 } 662 if (is_array($content) && isset($content['service_providers']) && is_array($content['service_providers'])) { 663 foreach ($content['service_providers'] as $index => $service_provider_class) { 664 $service_provider_class = trim($service_provider_class, '\\'); 665 $this->serviceProviderClasses['app']["$module:$index"] = $service_provider_class; 666 if ($service_provider_class === $class) { 667 // The deprecated implicit class name (*ServiceProvider) is listed 668 // explicitly under 'service_providers', in $module.services.yml. 669 unset($this->serviceProviderClasses['app'][$module]); 670 } 671 } 672 } 673 } 674 675 if (!empty($this->serviceProviderClasses['app'][$module])) { 676 @trigger_error("Implicit service providers are deprecated in Drupal 8.7.x and will be removed before Drupal 9.0.0. Instead declare your $module module service provider class $class in $module.services.yml file. See https://www.drupal.org/node/2974194.", E_USER_DEPRECATED); changed this line in version 5 of the diff
added 1 commit
- bc092d5f - Add missing service providers and move to top
661 } 662 if (is_array($content) && isset($content['service_providers']) && is_array($content['service_providers'])) { 663 foreach ($content['service_providers'] as $index => $service_provider_class) { 664 $service_provider_class = trim($service_provider_class, '\\'); 665 $this->serviceProviderClasses['app']["$module:$index"] = $service_provider_class; 666 if ($service_provider_class === $class) { 667 // The deprecated implicit class name (*ServiceProvider) is listed 668 // explicitly under 'service_providers', in $module.services.yml. 669 unset($this->serviceProviderClasses['app'][$module]); 670 } 671 } 672 } 673 } 674 675 if (!empty($this->serviceProviderClasses['app'][$module])) { 676 @trigger_error('Using implicit service providers is deprecated in drupal:11.2.0 and will be removed in drupal:12.0.0. Instead declare your $module module service provider class $class in $module.services.yml file. See https://www.drupal.org/node/2974194', E_USER_DEPRECATED); -
676 @trigger_error('Using implicit service providers is deprecated in drupal:11.2.0 and will be removed in drupal:12.0.0. Instead declare your $module module service provider class $class in $module.services.yml file. See https://www.drupal.org/node/2974194', E_USER_DEPRECATED); 676 @trigger_error("Using implicit service providers is deprecated in drupal:11.2.0 and will be removed in drupal:12.0.0. Instead declare your $module module service provider class $class in $module.services.yml file. See https://www.drupal.org/node/2974194", E_USER_DEPRECATED); changed this line in version 9 of the diff
Please register or sign in to reply