Skip to content
Snippets Groups Projects

Test with aria-label #3452724

Open Test with aria-label #3452724
issue/drupal-3452724:3452724-nav-label into 11.x
1 unresolved thread
Open Ivan Berdinsky requested to merge issue/drupal-3452724:3452724-nav-label into 11.x
1 unresolved thread

Closes #3452724

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #477181 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3452724

#477192

    Merge request pipeline passed for 1555004f

    Code Quality is loading
    Test summary results are being parsed
    Full report
    Metrics reports are loading
    Ready to merge by members who can write to the target branch.
    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/modules/navigation/templates/navigation-menu.html.twig
    1 1 {% import _self as menus %}
    2 2 <div class="admin-toolbar__item">
    3 <h4 class="visually-hidden focusable">{{ title }}</h4>
    4 <ul class="toolbar-block__list">
    5 {{ menus.menu_items(items, attributes, 0) }}
    6 </ul>
    3 <nav aria-label="{{ title }}">
    • m4olivei
      m4olivei @m4olivei

      I think this is a positive change. Only, we end up with a nested <nav> here, where the parent <nav> is defined in core/modules/navigation/layouts/navigation.html.twig which isn't great. You end up getting a double announcement for navigation, eg. (via Voiceover)

      "Administrative toolbar content, navigation"
[...]
"Shortcuts, navigation"
[...]
"Content, navigation"
[...]
"Administration, navigation"
[...]
"Administrative toolbar footer, navigation"
[...]
"Help, navigation"
[...]
"User, navigation"

      I think both "Administrative toolbar content, navigation" and "Administrative toolbar footer, navigation" are now redundant <nav>'s. The <nav> added here around each menu is much more useful and descriptive. Let’s remove the <nav> wrapper in core/modules/navigation/layouts/navigation.html.twig.

    • Ivan Berdinsky changed this line in version 14 of the diff

      changed this line in version 14 of the diff

    • Please register or sign in to reply
  • m4olivei added 1 commit

    added 1 commit

    • 0d8a0191 - Issue #3452724: Remove wrapping <nav> element in the navigation.html.twig template

    Compare with previous version

  • m4olivei added 145 commits

    added 145 commits

    Compare with previous version

  • m4olivei added 112 commits

    added 112 commits

    Compare with previous version

  • Ivan Berdinsky closed

    closed

  • Ivan Berdinsky reopened

    reopened

  • Ivan Berdinsky closed

    closed

  • Ivan Berdinsky reopened

    reopened

  • Ivan Berdinsky added 111 commits

    added 111 commits

    Compare with previous version

    Toggle commit list
  • Ivan Berdinsky added 1 commit

    added 1 commit

    • 61f676d6 - Removed useless div admin-toolbar__item

    Compare with previous version

  • Ivan Berdinsky added 1 commit

    added 1 commit

    • 1555004f - Removed useless div admin-toolbar__item

    Compare with previous version

  • Ivan Berdinsky closed

    closed

  • Ivan Berdinsky reopened

    reopened

  • T
    Tugboat.qa @tugboat
    Guest

    Tugboat has finished building the preview for this merge request!

    Link:

    Dashboard:

    • Please register or sign in to reply