3504477 - Make TranslatableMarkup slot-ready by wrapping it (!11114) · Merge requests · project / drupal · GitLab

Snippets Groups Projects

Closes #3504477

Activity

Ignacio Díaz-Roncero added 1 commit 5 months ago
added 1 commit

6320d2ec - 3504477 - Add test

Compare with previous version
Ignacio Díaz-Roncero added 1 commit 5 months ago
added 1 commit

125c1e1e - 3504477 - Correct test

Compare with previous version
Sascha Grossenbacher @berdir started a thread on an old version of the diff 4 months ago

core/lib/Drupal/Core/Render/Element/ComponentElement.php

109	110	"#plain_text" => (string) $slot_value,
110	111	];
111	112	}
	113	if ($slot_value instanceof TranslatableMarkup) {
Sascha Grossenbacher @berdir 4 months ago Developer Should we specifically limit this to FormatableMarkup or expand it to MarkupInterface or even \Stringable? m4olivei @m4olivei 4 months ago Looking at the class hierarchy of `\Drupal\Component\Render\MarkupInterface`, it does seem like there would be a use case for some of those at least, eg. `\Drupal\Core\GeneratedLink` `\Drupal\Component\Render\HtmlEscapedText` `\Drupal\media\IFrameMarkup` `\Drupal\filter\Render\FilteredMarkup` Sascha Grossenbacher changed this line in version 4 of the diff 3 months ago changed this line in version 4 of the diff Please register or sign in to reply

Sascha Grossenbacher added 252 commits 3 months ago

added 252 commits

125c1e1e...fc8a2834 - 248 commits from branch project:11.x
b1a341d0 - 3504477 - Make TranslatableMarkup slot-ready by wrapping it
5b78c659 - 3504477 - Add test
6cf45107 - 3504477 - Correct test
4623928b - use MarkupInterface, shorten test method description

Compare with previous version

Toggle commit list

Please register or sign in to reply