Skip to content
Snippets Groups Projects

global in remaining test modules

global in remaining test modules
issue/drupal-3497405:3497405-fix-drupalpractice.objects.globalfunction-in into 11.x
1 open thread
Closed
quietonerequested to merge
issue/drupal-3497405:3497405-fix-drupalpractice.objects.globalfunction-in into 11.x
1 open thread

Closes #3497405

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/modules/package_manager/tests/src/Unit/ValidationResultTest.php
22 22 * @dataProvider providerValidConstructorArguments
23 23 */
24 24 public function testCreateWarningResult(array $messages, ?string $summary): void {
25 // phpcs:ignore Drupal.Semantics.FunctionT.NotLiteralString
25 // phpcs:ignore Drupal.Semantics.FunctionT.NotLiteralString, DrupalPractice.Objects.GlobalFunction
26 26 $summary = $summary ? t($summary) : NULL;
  • Théodore Biadala
    Théodore Biadala @nod_
    Maintainer

    I don't quite get why translation is involved here, if anyone else know what's up feel free to commit, the rest of the MR looks good

  • quietone
    quietone @quietone
    Author Maintainer

    It is in the next line, where the second parameter must be of type TranslatableMarkup.

    $result = ValidationResult::createWarning($messages, $summary);

    This is common in the package manager tests.

  • Please register or sign in to reply
  • quietone added 2 commits

    added 2 commits

    • 68bf822f - 1 commit from branch project:11.x
    • 2adfb2ae - remove t not testing translation

    Compare with previous version

  • Stephen Mustgrave added 22 commits

    added 22 commits

    • 2adfb2ae...78bebf2b - 21 commits from branch project:11.x
    • f8f441c1 - Merge branch '11.x' of https://git.drupalcode.org/project/drupal into...

    Compare with previous version

  • catch closed

    closed

    • Please register or sign in to reply