Skip to content
Snippets Groups Projects

Closes #3496417

Open Closes #3496417
issue/drupal-3496417:3496417-fix-phpstan-missingtype.generics into 11.x
2 unresolved threads
Open mondrake requested to merge issue/drupal-3496417:3496417-fix-phpstan-missingtype.generics into 11.x
2 unresolved threads

Closes #3496417

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #434840 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3496417

#434841

    Merge request pipeline passed for f17660e1

    Code Quality is loading
    Test summary results are being parsed
    Full report
    Ready to merge by members who can write to the target branch.
    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • mondrake added 55 commits

    added 55 commits

    • 5eaea201...554b7c60 - 54 commits from branch project:11.x
    • 0b441427 - Merge branch '11.x' into 3496417-fix-phpstan-missingtype.generics

    Compare with previous version

  • Stephen Mustgrave resolved all threads

    resolved all threads

  • mondrake added 118 commits

    added 118 commits

    • 0b441427...7fff2643 - 117 commits from branch project:11.x
    • 37556c74 - Merge branch '11.x' into 3496417-fix-phpstan-missingtype.generics

    Compare with previous version

  • mondrake added 3 commits

    added 3 commits

    • 37556c74...68bf822f - 2 commits from branch project:11.x
    • 4501b2e7 - Merge branch '11.x' into 3496417-fix-phpstan-missingtype.generics

    Compare with previous version

  • catch @catch started a thread on the diff
    • core/lib/Drupal/Core/TypedData/ListInterface.php
    47 51 * @param int $index
    48 52 * Index of the item to return.
    49 53 *
    50 * @return \Drupal\Core\TypedData\TypedDataInterface|null
    54 * @return ?T
  • mondrake added 106 commits

    added 106 commits

    • 4501b2e7...6dd918c9 - 105 commits from branch project:11.x
    • f17660e1 - Merge branch drupal:11.x into 3496417-fix-phpstan-missingtype.generics

    Compare with previous version

  • Dave Long
    Dave Long @longwave started a thread on the diff
    • core/modules/jsonapi/src/JsonApiResource/ResourceObject.php
    297 297 * @param \Drupal\Core\Entity\ContentEntityInterface $entity
    298 298 * The config entity from which fields should be extracted.
    299 299 *
    300 * @return \Drupal\Core\Field\FieldItemListInterface[]
    300 * @return array<string,\Drupal\Core\Field\FieldItemListInterface<\Drupal\Core\Field\FieldItemInterface>>
    • Dave Long
      Dave Long @longwave ·
      Maintainer

      Spacing nit

      Suggested change
      300 * @return array<string,\Drupal\Core\Field\FieldItemListInterface<\Drupal\Core\Field\FieldItemInterface>>
      300 * @return array<string, \Drupal\Core\Field\FieldItemListInterface<\Drupal\Core\Field\FieldItemInterface>>
    • Please register or sign in to reply
    Please register or sign in to reply