Skip to content
Snippets Groups Projects

convert and move remaining core hook implementations

Open nicxvan requested to merge issue/drupal-3494908:3494908-pp-1-mark-several into 11.x
3 unresolved threads

Closes #3494908

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1 <?php
2
3 namespace Drupal\big_pipe\Hook;
4
5 use Drupal\Core\Hook\Attribute\Hook;
6
7 /**
8 * Theme suggestions for big_pipe.
9 */
10 class BigPipeThemeSuggestionHook {
  • nicxvan added 15 commits

    added 15 commits

    Compare with previous version

  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • nicxvan added 26 commits

    added 26 commits

    Compare with previous version

  • nicxvan added 1 commit

    added 1 commit

    Compare with previous version

  • 92 92 /**
    93 93 * Implements hook_modules_installed().
    94 94 *
    95 * @see block_themes_installed()
    95 * @see modulesInstalled()
    • Comment on lines -95 to +95

      This is should not be pointing to itself - it should be pointing to BlockThemesInstalledHook::themesInstalled...

      But imo this two hook implementations should be together as they are intimately related.

    • Please register or sign in to reply
  • 92 92 /**
    93 93 * Implements hook_modules_installed().
    94 94 *
    95 * @see block_themes_installed()
    95 * @see modulesInstalled()
    96 96 */
    97 97 #[Hook('modules_installed')]
    98 98 public function modulesInstalled($modules): void {
    99 // block_themes_installed() does not call block_theme_initialize() during site
    99 // modulesInstalled() does not call block_theme_initialize() during site
  • Alex Pott left review comments

    left review comments

  • Please register or sign in to reply
    Loading