Skip to content
Snippets Groups Projects

Skip caching in AssetResolver::getJsAssets if no libraries

Closed Skip caching in AssetResolver::getJsAssets if no libraries
issue/drupal-3494354:3494354-assetresolver-cid into 11.x
1 unresolved thread
Closed Michael Strelan requested to merge issue/drupal-3494354:3494354-assetresolver-cid into 11.x
1 unresolved thread

Closes #3494354

Merge request reports

Merge request pipeline #370507 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3494354

#370509

    Merge request pipeline passed for 8215a1ab

    Approval is optional

    Closed by catchcatch 2 months ago (Mar 21, 2025 4:16pm UTC)

    Merge details

    • The changes were not merged into 11.x.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/lib/Drupal/Core/Asset/AssetResolver.php
    313 313 return [[], []];
    314 314 }
    315 315
    316 // Skip caching if there are no libraries to load.
    317 if (!$libraries_to_load) {
    318 $cid = NULL;
    319 }
    • Comment on lines +316 to +319
      Michael Strelan
      Michael Strelan @mstrelan
      Author

      Could there be a scenario where there are libraries to load, but with different settings to the original request when the cache was cold? I'm guessing probably, but I've implemented it like this for now because it's simple and resolves my immediate issue.

    • Please register or sign in to reply
  • catch closed

    closed

    • Please register or sign in to reply