Skip to content
Snippets Groups Projects

Resolve #3269845 "Passing null to parameter #1 ($string) of type string is deprecated in _responsive_image_build_source_attributes()"

Open Resolve #3269845 "Passing null to parameter #1 ($string) of type string is deprecated in _responsive_image_build_source_attributes()"
issue/drupal-3269845:3269845-trim-passing-null-deprecated into 11.x
1 open thread
Open
Víctor Doradorequested to merge
issue/drupal-3269845:3269845-trim-passing-null-deprecated into 11.x
1 open thread

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #532039 passed

Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal-3269845

#532040

    Merge request pipeline passed for 0e92dda3

    Code Quality is loading
    Test summary results are being parsed
    Full report
    Metrics reports are loading
    Ready to merge by members who can write to the target branch.
    Loading

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    core/modules/responsive_image/responsive_image.module
    369 369 $source_attributes = new Attribute([
    370 370 'srcset' => implode(', ', array_unique($srcset)),
    371 371 ]);
    372 $media_query = trim($breakpoint->getMediaQuery());
    373 if (!empty($media_query)) {
    374 $source_attributes->setAttribute('media', $media_query);
    372 if ($breakpoint->hasMediaQuery()) {
    373 $source_attributes->setAttribute('media', $breakpoint->getMediaQuery());
  • andrew farquharson added 657 commits

    added 657 commits

    • 62ae848a...be9783de - 653 commits from branch project:11.x
    • 2bd0ed33 - Apply patch from #25
    • b993c754 - Make Breakpoint::getMediaQuery() always return a trimmed string (proposed in #18)
    • 5c2255c3 - Add tests
    • e0e847be - Improve the public interface of the Breakpoint class by adding a hasMediaQuery() method to it

    Compare with previous version

    Toggle commit list
  • Divyansh Gupta added 1 commit

    added 1 commit

    Compare with previous version

  • Divyansh Gupta added 3 commits

    added 3 commits

    • afa6861d...f9e5db1e - 2 commits from branch project:11.x
    • 0e92dda3 - Merge branch drupal:11.x into 3269845-trim-passing-null-deprecated

    Compare with previous version

  • catch closed

    closed

  • catch reopened

    reopened

  • T
    Tugboat.qa @tugboat
    Guest

    Tugboat has finished building the preview for this merge request!

    Link:

    Dashboard:

    • Please register or sign in to reply