Skip to content
Snippets Groups Projects

Patched the menu.active_trail service and added a test

Closed David Cameron requested to merge issue/drupal-1578832:1578832-front-active-trail-D11 into 11.x

Closes #1578832

Merge request reports

Code Quality is loading
Test summary results are being parsed
Metrics reports are loading

Closed by Lee RowlandsLee Rowlands 2 weeks ago (May 9, 2025 1:17am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Cameron added 1 commit

    added 1 commit

    • e0a0773c - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • David Cameron added 1 commit

    added 1 commit

    Compare with previous version

  • David Cameron added 88 commits

    added 88 commits

    • 76aecb76...38d18a4f - 85 commits from branch project:11.x
    • ec1671ff - Temporarily reverted .phpstan-baseline.php change
    • 23ca16a9 - Merge branch '11.x' into 1578832-front-active-trail-D11
    • 8ccf2c1d - Regenerated core/.phpstan-baseline.php

    Compare with previous version

  • David Cameron added 2 commits

    added 2 commits

    • 0503de29 - Revert "Regenerated core/.phpstan-baseline.php"
    • 4b824d03 - Deleted the functional test

    Compare with previous version

  • Víctor Dorado added 3 commits

    added 3 commits

    Compare with previous version

  • Stephen Mustgrave resolved all threads

    resolved all threads

  • 40 41 * The cache backend.
    41 42 * @param \Drupal\Core\Lock\LockBackendInterface $lock
    42 43 * The lock backend.
    44 * @param \Drupal\Core\Path\PathMatcherService $pathMatcher
    45 * The path.matcher service.
    43 46 */
    44 public function __construct(MenuLinkManagerInterface $menu_link_manager, RouteMatchInterface $route_match, CacheBackendInterface $cache, LockBackendInterface $lock) {
    47 public function __construct(MenuLinkManagerInterface $menu_link_manager, RouteMatchInterface $route_match, CacheBackendInterface $cache, LockBackendInterface $lock, protected PathMatcherInterface $pathMatcher) {
    45 48 parent::__construct(NULL, $cache, $lock);
    46 49 $this->menuLinkManager = $menu_link_manager;
  • 40 41 * The cache backend.
    41 42 * @param \Drupal\Core\Lock\LockBackendInterface $lock
    42 43 * The lock backend.
    44 * @param \Drupal\Core\Path\PathMatcherService $pathMatcher
    45 * The path.matcher service.
    43 46 */
    44 public function __construct(MenuLinkManagerInterface $menu_link_manager, RouteMatchInterface $route_match, CacheBackendInterface $cache, LockBackendInterface $lock) {
    47 public function __construct(MenuLinkManagerInterface $menu_link_manager, RouteMatchInterface $route_match, CacheBackendInterface $cache, LockBackendInterface $lock, protected PathMatcherInterface $pathMatcher) {
    • Suggested change
      Applied
      47 public function __construct(MenuLinkManagerInterface $menu_link_manager, RouteMatchInterface $route_match, CacheBackendInterface $cache, LockBackendInterface $lock, protected PathMatcherInterface $pathMatcher) {
      47 public function __construct(protected MenuLinkManagerInterface $menuLinkManager, protected RouteMatchInterface $routeMatch, CacheBackendInterface $cache, LockBackendInterface $lock, protected PathMatcherInterface $pathMatcher) {
    • andrew farquharson changed this line in version 14 of the diff

      changed this line in version 14 of the diff

    • Please register or sign in to reply
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading