Skip to content
Snippets Groups Projects

Issue #3493296 by penyaskito: Views exposed sort identifiers are not configurable when also exposed

Open Issue #3493296 by penyaskito: Views exposed sort identifiers are not configurable when also exposed
1 unresolved thread
1 unresolved thread

Issue #3493296: Views exposed sort identifiers are not configurable when also exposed Closes #3493296

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • added 1 commit

    • c6abf5a4 - Renamed keys. Added cache context for both keys.

    Compare with previous version

  • added 71 commits

    • c6abf5a4...5633ac7e - 68 commits from branch project:11.x
    • c0cdec66 - Issue #3493296 by penyaskito: Views exposed sort identifiers are not configurable when also exposed
    • 4427b7e4 - Code standards.
    • b6891a13 - Renamed keys. Added cache context for both keys.

    Compare with previous version

  • added 2 commits

    • 4569933a - Added tests.
    • b7e616f6 - Added validation and tests for the validation.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 2 commits

    Compare with previous version

  • resolved all threads

  • added 1 commit

    Compare with previous version

  • added 22 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 97951fce - Added constraints to the keys for config validation.

    Compare with previous version

  • resolved all threads

  • added 1 commit

    Compare with previous version

  • 157 * Sets the form error if $form_state is passed and returns the error string.
    158 *
    159 * @param string $key
    160 * The key to check.
    161 * @param string $value
    162 * The value to validate.
    163 * @param string|\Drupal\Core\StringTranslation\TranslatableMarkup $label
    164 * The label to use in the error message.
    165 * @param ?\Drupal\Core\Form\FormStateInterface $form_state
    166 * (optional) The form state to set any errors on.
    167 *
    168 * @return string|TranslatableMarkup
    169 * The error message if any, or an empty string.
    170 */
    171 protected function validateKey(string $key, string $value, string|TranslatableMarkup $label, ?FormStateInterface $form_state = NULL): string|TranslatableMarkup {
    172 $error = '';
    • I think we need to validate not only the format and the restricted error, but also avoid collisions with exposed filters keys and within the sort keys.

      Might need to be necessary to update DisplayPluginBase::isIdentifierUnique() to take into account the new configurable options.

    • Please register or sign in to reply
    Please register or sign in to reply
    Loading