Add query string to logo and favicon
2 unresolved threads
2 unresolved threads
Closes #1934508
Merge request reports
Activity
added 1 commit
- 9e9ee2a7 - Fix: Convert to non-capturing catch in theme.inc
added 130 commits
-
9e9ee2a7...a99e6d35 - 128 commits from branch
project:11.1.x
- a72fa314 - Ported the fix from #91 to 11.1.x.
- 25bd5d14 - Fix: Convert to non-capturing catch in theme.inc
-
9e9ee2a7...a99e6d35 - 128 commits from branch
added 1 commit
- afa850af - Support cache-busting string logic in logo tests
added 27 commits
-
afa850af...b0ef5921 - 24 commits from branch
project:11.1.x
- 88173f14 - Ported the fix from #91 to 11.1.x.
- def7babf - Fix: Convert to non-capturing catch in theme.inc
- 2f154916 - Support cache-busting string logic in logo tests
Toggle commit list-
afa850af...b0ef5921 - 24 commits from branch
250 250 /** @var \Drupal\Core\File\FileUrlGeneratorInterface $file_url_generator */ 251 251 $file_url_generator = \Drupal::service('file_url_generator'); 252 252 253 // A dummy query-string is added to filenames, to gain control over 254 // browser-caching. The string changes on every update or full cache 255 // flush, forcing browsers to load a new copy of the files, as the 256 // URL changed. 257 // We need try-catch due to the installer not having a state yet. - Comment on lines +253 to +257
From @alexpott's review in comment #88:
the comment is not wrapped correctly and the last sentence is not grammatically correct. Maybe We need to catch WhateverException since theme_get_setting() is used during the installer before the state service is available.
250 250 /** @var \Drupal\Core\File\FileUrlGeneratorInterface $file_url_generator */ 251 251 $file_url_generator = \Drupal::service('file_url_generator'); 252 252 253 // A dummy query-string is added to filenames, to gain control over 254 // browser-caching. The string changes on every update or full cache 255 // flush, forcing browsers to load a new copy of the files, as the 256 // URL changed. 257 // We need try-catch due to the installer not having a state yet. 258 try { 259 $query_string = \Drupal::service('asset.query_string')->get(); 260 } 261 catch (Exception) { 262 $query_string = '0'; 263 } - Comment on lines +258 to +263
From @alexpott's review in comment #88:
What is the specific exception we want to catch here? A general catch seems unwise.
Please register or sign in to reply