Issue #3109289: MediaEmbed conflates default view mode with user-selected view mode
4 unresolved threads
Merge request reports
Activity
added 1 commit
- 8d8aa84e - Use a fixture instead of installing media module in update test
124 124 sequence: 125 125 type: string 126 126 label: 'View mode' 127 default_view_mode_9301: Wondering if we should keep this name, or make it something like
fallback_view_mode
, and describe it as "The view mode to use if there is no data-view-mode attribute". If we expect to eventually discard this setting (i.e., whenmedia_update_9301()
is removed), then maybedefault_view_mode_9301
makes more sense. Thoughts?
295 284 return NULL; 296 285 } 297 286 298 $filter_default_view_mode = $media_embed_filter->settings['default_view_mode']; 287 $filter_default_view_mode = $media_embed_filter->settings['default_view_mode_9301']; 287 293 foreach ($xpath->query('//drupal-media[@data-entity-type="media" and normalize-space(@data-entity-uuid)!=""]') as $node) { 288 294 /** @var \DOMElement $node */ 289 295 $uuid = $node->getAttribute('data-entity-uuid'); 290 $view_mode_id = $node->getAttribute('data-view-mode') ?: $this->settings['default_view_mode']; 296 $view_mode_id = $node->getAttribute('data-view-mode') ?: $this->settings['default_view_mode_9301']; added 1 commit
- f80a3826 - Reorder config to satisify DemoUmamiProfileTest.
Please register or sign in to reply