Issue #3485435: Make Layout Builder Create Inline blocks logic optional
Closes #3485435
Merge request reports
Activity
60 60 */ 61 61 public $handles_permission_check = FALSE; 62 62 63 /** 64 * Indicates that this section storage allows inline block creation. 65 * 66 * If FALSE, the 'Create content block' link will be shown as part of the 67 * choose block off-canvas dialog. If TRUE, the link will be hidden and will 68 * not be possible to add new inline blocks from the Layout Builder UI. 69 * Defaults to FALSE. 70 * 71 * @var bool 72 * 73 * @see \Drupal\layout_builder\Controller\ChooseBlockController 74 */ 75 public $disable_inline_blocks = FALSE; changed this line in version 2 of the diff
That was exactly the initial name I used for this property
However, while testing, I had some issues with the upgrade path for LB collections in the tempstore where the new property was not defined yet. That's why I moved into a property whose value is FALSE by default.
To overcome this, added in this MR sentences like
$section_storage->getPluginDefinition()->get('allow_inline_blocks') ?? TRUEto check the value.My preferred approach would have been to clear all the items from the
LayoutTempStoreRepositoryto reload the values with the default set as TRUE. Made some tests, but I have not been able to find the way to flush all thelayout_builder.section_storage.*collections fromSharedTempStoreFactory.Is the current approach fine? Or do you have a better suggestion?
added 5 commits
-
3c1d6ffa...1afb8711 - 2 commits from branch
project:11.x - 3c5625c5 - Merge remote-tracking branch 'origin/11.x' into 3485435-layout-builder-create
- 72ebf792 - Rename SectionStorage property to avoid double negative
- 455dab1c - Adapt code to work with missing properties
Toggle commit list-
3c1d6ffa...1afb8711 - 2 commits from branch
added 404 commits
-
7b8b597f...ba9b75f6 - 403 commits from branch
project:11.x - 96ac66fb - Merge remote-tracking branch 'origin/11.x' into 3485435-layout-builder-create
-
7b8b597f...ba9b75f6 - 403 commits from branch
added 81 commits
-
96ac66fb...7488aea7 - 80 commits from branch
project:11.x - 6b9611c8 - Merge remote-tracking branch 'origin/11.x' into 3485435-layout-builder-create
-
96ac66fb...7488aea7 - 80 commits from branch
added 154 commits
-
5d439605...401a157f - 153 commits from branch
project:11.x - e54cdbd8 - Merge remote-tracking branch 'origin/11.x' into 3485435-layout-builder-create
-
5d439605...401a157f - 153 commits from branch
added 43 commits
-
e54cdbd8...27788820 - 42 commits from branch
project:11.x - 5f5ac3fd - Merge remote-tracking branch 'origin/11.x' into 3485435-layout-builder-create
-
e54cdbd8...27788820 - 42 commits from branch
