Skip to content
Snippets Groups Projects
  1. Nov 15, 2004
  2. Nov 14, 2004
    • Dries Buytaert's avatar
      - Modified patch by Jeremy: throttle module improvements and fixes: · ef95773b
      Dries Buytaert authored
         + throttle module: flush cache when the throttle enables/disables
         + throttle module: prevent throttle being enabled by 0 users or guests when disabled
         + system module: remove requirement for statistics.module
         + block module: update help text to reflect access log is no longer required
         + statistics module: throttle is now enabled/disabled, not using levels 0-5
      ef95773b
    • Dries Buytaert's avatar
      · 9998d2a1
      Dries Buytaert authored
      - Patch #12886 by thorne: fixed XHTML problem: the bluemarine theme used a border=0 attribute on the img tag for the site logo.
      9998d2a1
  3. Nov 08, 2004
  4. Nov 07, 2004
    • Dries Buytaert's avatar
      - Refactored the throttle module. Patch by Jeremy and me. · 3769665b
      Dries Buytaert authored
        * There are only two throttle levels instead of 5, namely 'enabled' and 'disabled'.  This makes it a _lot_ easier to predict when the throttle will kick in.  However, if you maintain a module that is throttle-aware, it needs to be updated!
      
        * The throttle mechanism now uses the current number of anonymous users or the current number of authenticated users to kick in.  This is a _lot_ more intuitive than the old throttle mechanism.
      
        * The throttle block has been removed -- you can now use the "Who's online" block to determine the good throttle settings.
      
        * Most of the documentation has been removed because it was deprecated.
      
        * It's less code!
      3769665b
    • Dries Buytaert's avatar
      · f01bd675
      Dries Buytaert authored
      - Performance improvement: made 'sid' the primary key of the sessions table.
        That should improve performance of session handling as well improve
        performance of the "Who's online"-block.  Drupal.org's sessions table
        contains appr. 40.000 sessions on a slow day and rendering the "Who's
        online"-block became a performance bottleneck.
      
        This change has yet to be tested on a busy site so things might go wrong.
      f01bd675
    • Dries Buytaert's avatar
      · 7a5884cd
      Dries Buytaert authored
      - Patch #11427: added 'edit own forum topics' permission.
      7a5884cd
    • Dries Buytaert's avatar
      - Patch #12658 by menesis: when an administrator adds a user, the... · a16be349
      Dries Buytaert authored
      - Patch #12658 by menesis: when an administrator adds a user, the 'authenticated user' role was not assigned to the new user.
      a16be349
  5. Nov 06, 2004
  6. Nov 04, 2004
    • Dries Buytaert's avatar
      - Patch #10632 by Gerhard: the book permissions in today's cvs are not... · bb3df8a1
      Dries Buytaert authored
      - Patch #10632 by Gerhard: the book permissions in today's cvs are not consistent with the rest of Drupal. We have a "maintain books" and a "edit own book pages" permission. All other modules have a "create foo" permission. Thus the existing "maintain books" permission should be renamed to "create book pages" and a new "maintain books" permission should be introduced that allows editors to update book pages they haven't created themselves even without having "administer nodes" permission.
      bb3df8a1
    • Dries Buytaert's avatar
      · b3e3f8ae
      Dries Buytaert authored
      - Updated forum_block() to pass comment_count's to node_title_list().  This eliminates up to 10 SQL queries (sometimes less) for each non-cached page view on drupal.org.  Derived from ccourtne's patch.
      b3e3f8ae
    • Dries Buytaert's avatar
      · 14353d18
      Dries Buytaert authored
      - Slightly modified the API of node_title_list(): it will no longer call comment_num_all() for each node.  Instead, it checks for the availability of the node_comment field, available through the node_comment_statistics table.  If updated the Doxygen comments accordingly.
      
        People were using node_title_list() without realizing it would do numereous database queries.  This change greatly reduces the number of database queries required to render the node statistics block as well as to render the forum block (coming up next).
      
        If your module is using node_title_list() and you want the number of comments to be shown as title attributes, chances are you have to update your SQL query to join node_comment_statistics.
      14353d18
    • Dries Buytaert's avatar
      - Modifed patch by ccourtne: made the tracker module take advantage of the... · 7ad36e3f
      Dries Buytaert authored
      - Modifed patch by ccourtne: made the tracker module take advantage of the node_comment_statistics table.  Improves performance of the tracker page by facter 10 because it eliminates up to 20 SQL queries.
      7ad36e3f
    • Dries Buytaert's avatar
      - Patch #12232 by Steven: more search improvements: · b6eee48c
      Dries Buytaert authored
         + When a comment is posted, a node needs to be re-indexed. Luckily, we can use node_comment_statistics for this easily.
         + When a node is deleted, it should be deleted from the search index as well.
         + The search wipe didn't properly remove links to nodes from the index.
         + Section url was faulty in _help.
         + Minor code rearrangement.
      b6eee48c
    • Steven Wittens's avatar
      Fixing bad UTF-8. · d13943e2
      Steven Wittens authored
      d13943e2
  7. Nov 03, 2004
  8. Nov 02, 2004
  9. Oct 31, 2004
    • Dries Buytaert's avatar
      - Patch #7161 by jhriggs: fixed probem with 'last page' link not being correct... · 29b32eff
      Dries Buytaert authored
      - Patch #7161 by jhriggs: fixed probem with 'last page' link not being correct under certain circumstances.
      29b32eff
    • Dries Buytaert's avatar
      - Updated CHANGELOG.txt · 4021b429
      Dries Buytaert authored
      4021b429
    • Dries Buytaert's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries Buytaert authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
      b3adcf05
    • Dries Buytaert's avatar
      - Patch #12232 by Steven/UnConed: search module improvements. · 8daed9cb
      Dries Buytaert authored
      1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
      
      2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
      
      3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
      
      4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
      
      5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
      
      6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
      
      7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
      
      8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
      
      9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
      
      10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
      8daed9cb
  10. Oct 30, 2004
  11. Oct 29, 2004
Loading