Skip to content
Snippets Groups Projects
  1. Oct 05, 2006
  2. Aug 31, 2006
  3. Aug 27, 2006
  4. Aug 26, 2006
  5. Aug 23, 2006
  6. Aug 20, 2006
  7. Aug 18, 2006
  8. Aug 10, 2006
  9. Aug 07, 2006
  10. Aug 06, 2006
  11. Jul 31, 2006
  12. Jul 27, 2006
  13. Jul 19, 2006
  14. Jul 04, 2006
  15. May 18, 2006
  16. May 15, 2006
  17. May 07, 2006
  18. May 04, 2006
  19. Mar 27, 2006
  20. Feb 21, 2006
  21. Jan 26, 2006
  22. Jan 20, 2006
    • Dries Buytaert's avatar
      - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 · 8c02d4ec
      Dries Buytaert authored
      When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
      
      # Assign a decimal placeholder weight to preserve original array order
      if (!isset($form[$key]['#weight'])) {
        $form[$key]['#weight'] = $count/1000;
      }
      
      The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
      
      Consider the following pseudo example:
      
      $form['game_title'] = array(
          '#type' => 'textfield',
          ...
          );
      $form['game_description'] = array(
          '#type' => 'textarea',
          ...
          );
      $form['game_format'] = filter_form(variable_get('game_format', NULL));
      return $form;
      
      Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
      
      The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
      8c02d4ec
  23. Jan 19, 2006
  24. Jan 18, 2006
  25. Dec 29, 2005
  26. Dec 05, 2005
  27. Nov 23, 2005
  28. Nov 12, 2005
  29. Nov 01, 2005
  30. Oct 11, 2005
  31. Oct 07, 2005
  32. Sep 28, 2005
  33. Sep 23, 2005
  34. Sep 18, 2005
    • Dries Buytaert's avatar
      - Patch #3986 by James (and Boris :)):consolidated all feed-related settings in one place. · 1dc53d97
      Dries Buytaert authored
      * adds a "feed settings" section to admin/settings where 2 new settings are introduced:
      * number of items per feed
      * default length of feed descriptions (title only, teaser, full)
      * patches all of core to obey the above - including the new aggregator (out) feeds
      * adds support for adding namespaces in _nodeapi('rss item') - which means things like iTunes RSS and yahoo's media rss can be implemented by the appropriate modules (i.e. audio.module)
      * includes some additional info in the default node feed - specifically the element (links directly to comments) - and dc:creator - to show node author information.
      1dc53d97
  35. Sep 14, 2005
Loading