Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
project
drupal
Commits
ff3cf132
Commit
ff3cf132
authored
Sep 19, 2001
by
natrak
Browse files
- fixed comments using the timestamp of the comment, and not the timestamp
of the user. (Should stop using * in SQL queries :-)
parent
288f1986
Changes
1
Hide whitespace changes
Inline
Side-by-side
includes/comment.inc
View file @
ff3cf132
...
...
@@ -181,7 +181,7 @@ function comment_order($order) {
}
function
comment_query
(
$lid
,
$order
,
$pid
=
-
1
)
{
$query
.
=
"SELECT
c
.*,
u
.* FROM comments c LEFT JOIN user u ON c.author = u.uid WHERE c.lid = '
$lid
'"
;
$query
.
=
"SELECT
u
.*,
c
.* FROM comments c LEFT JOIN user u ON c.author = u.uid WHERE c.lid = '
$lid
'"
;
if
(
$pid
>=
0
)
$query
.
=
" AND pid = '
$pid
'"
;
if
(
$order
==
1
)
$query
.
=
" ORDER BY c.timestamp DESC"
;
else
if
(
$order
==
2
)
$query
.
=
" ORDER BY c.timestamp"
;
...
...
@@ -222,7 +222,7 @@ function comment_view($comment, $folded = 0) {
function
comment_thread_min
(
$cid
,
$threshold
)
{
global
$user
;
$result
=
db_query
(
"SELECT
c
.*,
u
.* FROM comments c LEFT JOIN user u ON c.author = u.uid WHERE c.pid = '
$cid
' ORDER BY c.timestamp, c.cid"
);
$result
=
db_query
(
"SELECT
u
.*,
c
.* FROM comments c LEFT JOIN user u ON c.author = u.uid WHERE c.pid = '
$cid
' ORDER BY c.timestamp, c.cid"
);
while
(
$comment
=
db_fetch_object
(
$result
))
{
print
"<ul>"
;
...
...
@@ -244,7 +244,7 @@ function comment_thread_max($cid, $mode, $threshold, $level = 0, $dummy = 0) {
** terms of speed and size.
*/
$result
=
db_query
(
"SELECT
c
.*,
u
.* FROM comments c LEFT JOIN user u ON c.author = u.uid WHERE c.pid = '
$cid
' ORDER BY c.timestamp, c.cid"
);
$result
=
db_query
(
"SELECT
u
.*,
c
.* FROM comments c LEFT JOIN user u ON c.author = u.uid WHERE c.pid = '
$cid
' ORDER BY c.timestamp, c.cid"
);
while
(
$comment
=
db_fetch_object
(
$result
))
{
print
"<table border=
\"
0
\"
cellpadding=
\"
0
\"
cellspacing=
\"
0
\"
width=
\"
100%
\"
><tr><td width=
\"
"
.
(
$level
*
25
)
.
"
\"
> </td><td>
\n
"
;
...
...
@@ -277,7 +277,7 @@ function comment_render($lid, $cid) {
}
if
(
$cid
>
0
)
{
$result
=
db_query
(
"SELECT
c
.*,
u
.* FROM comments c LEFT JOIN user u ON c.author = u.uid WHERE cid = '
$cid
'"
);
$result
=
db_query
(
"SELECT
u
.*,
c
.* FROM comments c LEFT JOIN user u ON c.author = u.uid WHERE cid = '
$cid
'"
);
if
(
$comment
=
db_fetch_object
(
$result
))
{
comment_view
(
$comment
,
comment_links
(
$comment
));
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment