Issue #3454603 by phenaproxima, thejimbirch, Prashant.c, alexpott: Many core...

Issue #3454603 by phenaproxima, thejimbirch, Prashant.c, alexpott: Many core recipes are not idempotent

(cherry picked from commit 9f3ee1ff)

core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php

@@ -191,6 +191,7 @@ public function disable() {
   /**
    * {@inheritdoc}
    */
+  #[ActionMethod(adminLabel: new TranslatableMarkup('Set status'), pluralize: FALSE)]
   public function setStatus($status) {
     $this->status = (bool) $status;
     return $this;

core/modules/block/src/Entity/Block.php

@@ -4,12 +4,14 @@
 
 use Drupal\Core\Cache\Cache;
 use Drupal\Core\Condition\ConditionPluginCollection;
+use Drupal\Core\Config\Action\Attribute\ActionMethod;
 use Drupal\Core\Config\Entity\ConfigEntityBase;
 use Drupal\block\BlockPluginCollection;
 use Drupal\block\BlockInterface;
 use Drupal\Core\Config\Entity\ConfigEntityInterface;
 use Drupal\Core\Entity\EntityWithPluginCollectionInterface;
 use Drupal\Core\Entity\EntityStorageInterface;
+use Drupal\Core\StringTranslation\TranslatableMarkup;
 
 /**
  * Defines a Block configuration entity class.
@@ -310,6 +312,7 @@ protected function conditionPluginManager() {
   /**
    * {@inheritdoc}
    */
+  #[ActionMethod(adminLabel: new TranslatableMarkup('Set region'), pluralize: FALSE)]
   public function setRegion($region) {
     $this->region = $region;
     return $this;
@@ -318,6 +321,7 @@ public function setRegion($region) {
   /**
    * {@inheritdoc}
    */
+  #[ActionMethod(adminLabel: new TranslatableMarkup('Set weight'), pluralize: FALSE)]
   public function setWeight($weight) {
     $this->weight = $weight;
     return $this;

core/recipes/article_content_type/config/core.entity_form_display.node.article.default.yml

-langcode: en
-status: true
-dependencies:
-  config:
-    - field.field.node.article.body
-    - field.field.node.article.field_image
-    - image.style.thumbnail
-    - node.type.article
-  module:
-    - image
-    - path
-    - text
-id: node.article.default
-targetEntityType: node
-bundle: article
-mode: default
-content:
-  body:
-    type: text_textarea_with_summary
-    weight: 2
-    region: content
-    settings:
-      rows: 9
-      summary_rows: 3
-      placeholder: ''
-      show_summary: false
-    third_party_settings: {  }
-  created:
-    type: datetime_timestamp
-    weight: 10
-    region: content
-    settings: {  }
-    third_party_settings: {  }
-  field_image:
-    type: image_image
-    weight: 1
-    region: content
-    settings:
-      progress_indicator: throbber
-      preview_image_style: thumbnail
-    third_party_settings: {  }
-  path:
-    type: path
-    weight: 30
-    region: content
-    settings: {  }
-    third_party_settings: {  }
-  promote:
-    type: boolean_checkbox
-    weight: 15
-    region: content
-    settings:
-      display_label: true
-    third_party_settings: {  }
-  status:
-    type: boolean_checkbox
-    weight: 120
-    region: content
-    settings:
-      display_label: true
-    third_party_settings: {  }
-  sticky:
-    type: boolean_checkbox
-    weight: 16
-    region: content
-    settings:
-      display_label: true
-    third_party_settings: {  }
-  title:
-    type: string_textfield
-    weight: 0
-    region: content
-    settings:
-      size: 60
-      placeholder: ''
-    third_party_settings: {  }
-  uid:
-    type: entity_reference_autocomplete
-    weight: 5
-    region: content
-    settings:
-      match_operator: CONTAINS
-      match_limit: 10
-      size: 60
-      placeholder: ''
-    third_party_settings: {  }
-hidden: {  }

core/recipes/article_content_type/config/core.entity_view_display.node.article.default.yml

-langcode: en
-status: true
-dependencies:
-  config:
-    - field.field.node.article.body
-    - field.field.node.article.field_image
-    - image.style.wide
-    - node.type.article
-  module:
-    - image
-    - text
-    - user
-id: node.article.default
-targetEntityType: node
-bundle: article
-mode: default
-content:
-  body:
-    type: text_default
-    label: hidden
-    settings: {  }
-    third_party_settings: {  }
-    weight: 0
-    region: content
-  field_image:
-    type: image
-    label: hidden
-    settings:
-      image_style: wide
-      image_link: ''
-      image_loading:
-        attribute: eager
-    third_party_settings: {  }
-    weight: -1
-    region: content
-  links:
-    settings: {  }
-    third_party_settings: {  }
-    weight: 100
-    region: content
-hidden: {  }

core/recipes/article_content_type/config/core.entity_view_display.node.article.rss.yml

-langcode: en
-status: true
-dependencies:
-  config:
-    - core.entity_view_mode.node.rss
-    - field.field.node.article.body
-    - field.field.node.article.field_image
-    - node.type.article
-  module:
-    - user
-id: node.article.rss
-targetEntityType: node
-bundle: article
-mode: rss
-content:
-  links:
-    weight: 100
-    region: content
-hidden:
-  body: true
-  field_image: true

core/recipes/article_content_type/config/core.entity_view_display.node.article.teaser.yml

-langcode: en
-status: true
-dependencies:
-  config:
-    - core.entity_view_mode.node.teaser
-    - field.field.node.article.body
-    - field.field.node.article.field_image
-    - image.style.medium
-    - node.type.article
-  module:
-    - image
-    - text
-    - user
-id: node.article.teaser
-targetEntityType: node
-bundle: article
-mode: teaser
-content:
-  body:
-    type: text_summary_or_trimmed
-    label: hidden
-    settings:
-      trim_length: 600
-    third_party_settings: {  }
-    weight: 0
-    region: content
-  field_image:
-    type: image
-    label: hidden
-    settings:
-      image_style: medium
-      image_link: content
-      image_loading:
-        attribute: lazy
-    third_party_settings: {  }
-    weight: -1
-    region: content
-  links:
-    weight: 100
-    region: content
-hidden: {  }

core/recipes/article_content_type/config/field.field.node.article.body.yml

@@ -19,4 +19,5 @@ default_value_callback: ''
 settings:
   display_summary: true
   required_summary: false
+  allowed_formats: {  }
 field_type: text_with_summary

core/recipes/article_content_type/recipe.yml

@@ -26,3 +26,119 @@ config:
       - image.style.medium
       - image.style.thumbnail
       - image.style.wide
+  actions:
+    core.entity_form_display.node.article.default:
+      createIfNotExists:
+        targetEntityType: node
+        bundle: article
+        mode: default
+        status: true
+      setComponents:
+        - name: body
+          options:
+            type: text_textarea_with_summary
+            weight: 2
+            region: content
+        - name: created
+          options:
+            type: datetime_timestamp
+            weight: 10
+            region: content
+        - name: field_image
+          options:
+            type: image_image
+            weight: 1
+            region: content
+        - name: path
+          options:
+            type: path
+            weight: 30
+            region: content
+        - name: promote
+          options:
+            type: boolean_checkbox
+            weight: 15
+            region: content
+        - name: status
+          options:
+            type: boolean_checkbox
+            weight: 120
+            region: content
+        - name: sticky
+          options:
+            type: boolean_checkbox
+            weight: 16
+            region: content
+        - name: title
+          options:
+            type: string_textfield
+            weight: 0
+            region: content
+        - name: uid
+          options:
+            type: entity_reference_autocomplete
+            weight: 5
+            region: content
+    core.entity_view_display.node.article.default:
+      createIfNotExists:
+        targetEntityType: node
+        bundle: article
+        mode: default
+        status: true
+      setComponents:
+        - name: body
+          options:
+            type: text_default
+            label: hidden
+            weight: 0
+            region: content
+        - name: field_image
+          options:
+            type: image
+            label: hidden
+            settings:
+              image_style: wide
+              image_loading:
+                attribute: eager
+            weight: -1
+            region: content
+        - name: links
+          options:
+            weight: 100
+            region: content
+    core.entity_view_display.node.article.rss:
+      createIfNotExists:
+        targetEntityType: node
+        bundle: article
+        mode: rss
+        status: true
+        content:
+          links:
+            weight: 100
+            region: content
+    core.entity_view_display.node.article.teaser:
+      createIfNotExists:
+        targetEntityType: node
+        bundle: article
+        mode: teaser
+        status: true
+        content:
+          links:
+            weight: 100
+            region: content
+      setComponents:
+        - name: body
+          options:
+            type: text_summary_or_trimmed
+            label: hidden
+            weight: 0
+            region: content
+        - name: field_image
+          options:
+            type: image
+            label: hidden
+            settings:
+              image_style: medium
+              image_link: content
+            weight: -1
+            region: content

core/recipes/basic_block_type/config/field.field.block_content.basic.body.yml

@@ -19,4 +19,5 @@ default_value_callback: ''
 settings:
   display_summary: false
   required_summary: false
+  allowed_formats: {  }
 field_type: text_with_summary

core/recipes/basic_html_format_editor/config/filter.format.basic_html.yml

@@ -6,8 +6,6 @@ dependencies:
 name: 'Basic HTML'
 format: basic_html
 weight: 0
-roles:
-  - authenticated
 filters:
   editor_file_reference:
     id: editor_file_reference

core/recipes/comment_base/config/field.field.comment.comment.comment_body.yml

@@ -16,5 +16,6 @@ required: true
 translatable: true
 default_value: {  }
 default_value_callback: ''
-settings: {  }
+settings:
+  allowed_formats: {  }
 field_type: text_long

core/recipes/core_recommended_admin_theme/recipe.yml

@@ -9,16 +9,28 @@ config:
     system:
       - system.menu.account
       - system.menu.main
-      - system.theme
     claro:
       - block.block.claro_breadcrumbs
       - block.block.claro_content
       - block.block.claro_local_actions
       - block.block.claro_messages
-      - block.block.claro_page_title
       - block.block.claro_primary_local_tasks
       - block.block.claro_secondary_local_tasks
   actions:
+    # Create this block dynamically so as not to conflict with the block created
+    # by block_theme_initialize() when Claro is installed.
+    block.block.claro_page_title:
+      createIfNotExists:
+        theme: claro
+        plugin: page_title_block
+        settings:
+          id: page_title_block
+          label: 'Page title'
+          label_display: '0'
+          provider: core
+      setRegion: header
+      setStatus: true
+      setWeight: -30
     system.theme:
       simpleConfigUpdate:
         admin: claro

core/recipes/core_recommended_front_end_theme/recipe.yml

@@ -9,14 +9,11 @@ config:
     system:
       - system.menu.account
       - system.menu.main
-      - system.theme
     olivero:
       - block.block.olivero_account_menu
       - block.block.olivero_breadcrumbs
       - block.block.olivero_content
       - block.block.olivero_main_menu
-      - block.block.olivero_messages
-      - block.block.olivero_page_title
       - block.block.olivero_powered
       - block.block.olivero_primary_admin_actions
       - block.block.olivero_primary_local_tasks
@@ -24,6 +21,32 @@ config:
       - block.block.olivero_site_branding
       - core.date_format.olivero_medium
   actions:
+    # Create these blocks dynamically so as not to conflict with the blocks created
+    # by block_theme_initialize() when Olivero is installed.
+    block.block.olivero_messages:
+      createIfNotExists:
+        theme: olivero
+        plugin: system_messages_block
+        settings:
+          id: system_messages_block
+          label: 'Status messages'
+          label_display: '0'
+          provider: system
+      setRegion: highlighted
+      setStatus: true
+      setWeight: -5
+    block.block.olivero_page_title:
+      createIfNotExists:
+        theme: olivero
+        plugin: page_title_block
+        settings:
+          id: page_title_block
+          label: 'Page title'
+          label_display: '0'
+          provider: core
+      setRegion: content_above
+      setStatus: true
+      setWeight: -5
     system.theme:
       simpleConfigUpdate:
         default: olivero

core/recipes/full_html_format_editor/config/filter.format.full_html.yml

@@ -6,8 +6,6 @@ dependencies:
 name: 'Full HTML'
 format: full_html
 weight: 2
-roles:
-  - administrator
 filters:
   editor_file_reference:
     id: editor_file_reference

core/recipes/page_content_type/config/field.field.node.page.body.yml

@@ -19,4 +19,5 @@ default_value_callback: ''
 settings:
   display_summary: true
   required_summary: false
+  allowed_formats: {  }
 field_type: text_with_summary

core/recipes/remote_video_media_type/recipe.yml

@@ -21,3 +21,4 @@ config:
       - views.view.media
     image:
       - image.style.medium
+      - image.style.thumbnail

core/recipes/standard_responsive_images/config/image.style.max_1300x1300.yml

 langcode: en
 dependencies:
-  module:
-    - responsive_image
   enforced:
     module:
       - responsive_image
@@ -22,3 +20,4 @@ effects:
     weight: 2
     data:
       extension: webp
+status: true

core/recipes/standard_responsive_images/config/image.style.max_2600x2600.yml

 langcode: en
 dependencies:
-  module:
-    - responsive_image
   enforced:
     module:
       - responsive_image
@@ -22,3 +20,4 @@ effects:
     weight: 2
     data:
       extension: webp
+status: true

core/recipes/standard_responsive_images/config/image.style.max_325x325.yml

 langcode: en
 dependencies:
-  module:
-    - responsive_image
   enforced:
     module:
       - responsive_image
@@ -22,3 +20,4 @@ effects:
     weight: 2
     data:
       extension: webp
+status: true

core/recipes/standard_responsive_images/config/image.style.max_650x650.yml

 langcode: en
 dependencies:
-  module:
-    - responsive_image
   enforced:
     module:
       - responsive_image
@@ -22,3 +20,4 @@ effects:
     weight: 2
     data:
       extension: webp
+status: true