Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
project
drupal
Commits
f39127ce
Commit
f39127ce
authored
Sep 14, 2017
by
catch
Browse files
Issue
#2901718
by mfernea: Fix 'Squiz.ControlStructures.ForEachLoopDeclaration' coding standard
parent
da9c5ba2
Changes
5
Hide whitespace changes
Inline
Side-by-side
core/lib/Drupal/Core/Menu/LocalTaskManager.php
View file @
f39127ce
...
...
@@ -234,7 +234,7 @@ public function getLocalTasksForRoute($route_name) {
if
(
$base_routes
)
{
// Find all the plugins with the same root and that are at the top
// level or that have a visible parent.
foreach
(
$definitions
as
$plugin_id
=>
$task_info
)
{
foreach
(
$definitions
as
$plugin_id
=>
$task_info
)
{
if
(
!
empty
(
$base_routes
[
$task_info
[
'base_route'
]])
&&
(
empty
(
$task_info
[
'parent_id'
])
||
!
empty
(
$parents
[
$task_info
[
'parent_id'
]])))
{
// Concat '> ' with root ID for the parent of top-level tabs.
$parent
=
empty
(
$task_info
[
'parent_id'
])
?
'> '
.
$task_info
[
'base_route'
]
:
$task_info
[
'parent_id'
];
...
...
core/modules/color/color.module
View file @
f39127ce
...
...
@@ -80,7 +80,7 @@ function color_library_info_alter(&$libraries, $extension) {
if
(
isset
(
$libraries
[
$name
][
'css'
]))
{
// Override stylesheets.
foreach
(
$libraries
[
$name
][
'css'
]
as
$category
=>
$css_assets
)
{
foreach
(
$css_assets
as
$path
=>
$metadata
)
{
foreach
(
$css_assets
as
$path
=>
$metadata
)
{
// Loop over the path array with recolored CSS files to find matching
// paths which could replace the non-recolored paths.
foreach
(
$color_paths
as
$color_path
)
{
...
...
core/modules/search/src/Plugin/views/argument/Search.php
View file @
f39127ce
...
...
@@ -97,7 +97,7 @@ public function query($group_by = FALSE) {
$search_dataset
=
$this
->
query
->
addTable
(
'node_search_dataset'
);
$conditions
=
$this
->
searchQuery
->
conditions
();
$condition_conditions
=&
$conditions
->
conditions
();
foreach
(
$condition_conditions
as
$key
=>
&
$condition
)
{
foreach
(
$condition_conditions
as
$key
=>
&
$condition
)
{
// Make sure we just look at real conditions.
if
(
is_numeric
(
$key
))
{
// Replace the conditions with the table alias of views.
...
...
core/modules/search/src/Plugin/views/filter/Search.php
View file @
f39127ce
...
...
@@ -172,7 +172,7 @@ public function query() {
$search_dataset
=
$this
->
query
->
addTable
(
'node_search_dataset'
);
$conditions
=
$this
->
searchQuery
->
conditions
();
$condition_conditions
=&
$conditions
->
conditions
();
foreach
(
$condition_conditions
as
$key
=>
&
$condition
)
{
foreach
(
$condition_conditions
as
$key
=>
&
$condition
)
{
// Make sure we just look at real conditions.
if
(
is_numeric
(
$key
))
{
// Replace the conditions with the table alias of views.
...
...
core/phpcs.xml.dist
View file @
f39127ce
...
...
@@ -147,6 +147,17 @@
</rule>
<!-- Squiz sniffs -->
<rule
ref=
"Squiz.ControlStructures.ForEachLoopDeclaration"
/>
<!-- Disable some error messages that we already cover. -->
<rule
ref=
"Squiz.ControlStructures.ForEachLoopDeclaration.AsNotLower"
>
<severity>
0
</severity>
</rule>
<rule
ref=
"Squiz.ControlStructures.ForEachLoopDeclaration.SpaceAfterOpen"
>
<severity>
0
</severity>
</rule>
<rule
ref=
"Squiz.ControlStructures.ForEachLoopDeclaration.SpaceBeforeClose"
>
<severity>
0
</severity>
</rule>
<rule
ref=
"Squiz.ControlStructures.ForLoopDeclaration"
/>
<!-- Disable some error messages that we already cover. -->
<rule
ref=
"Squiz.ControlStructures.ForLoopDeclaration.SpacingAfterOpen"
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment