Issue #3463286 by catch: Fix selenium performance/stampede issues in gitlab...

Issue #3463286 by catch: Fix selenium performance/stampede issues in gitlab config and BrowserTestBase

.gitlab-ci/pipeline.yml

@@ -92,7 +92,9 @@ variables:
   variables:
     JAVA_OPTS: "-Dwebdriver.chrome.logfile=/builds/chromedriver.log"
     SE_NODE_OVERRIDE_MAX_SESSIONS: "true"
-    SE_NODE_MAX_SESSIONS: "5"
+    SE_NODE_MAX_SESSIONS: "16"
+    SE_SESSION_RETRY_INTERVAL: "1"
+    SE_SESSION_REQUEST_TIMEOUT: "10"
     SE_START_XVFB: "false"
     SE_START_VNC: "false"
 
@@ -136,10 +138,10 @@ variables:
 
 '🖱️️️ PHPUnit Functional Javascript':
   <<: [ *with-composer, *run-tests, *default-job-settings ]
-  parallel: 4
+  parallel: 2
   variables:
     TESTSUITE: PHPUnit-FunctionalJavascript
-    CONCURRENCY: 15
+    CONCURRENCY: 8
     KUBERNETES_CPU_REQUEST: "24"
   services:
     - <<: *with-database

core/tests/Drupal/Tests/BrowserTestBase.php

@@ -431,6 +431,11 @@ protected function cleanupEnvironment() {
    * {@inheritdoc}
    */
   protected function tearDown(): void {
+    // Close any mink sessions as early as possible to free a new browser
+    // session up for the next test method or test.
+    if ($this->mink) {
+      $this->mink->stopSessions();
+    }
     parent::tearDown();
 
     if ($this->container) {
@@ -450,10 +455,6 @@ protected function tearDown(): void {
     // Ensure that internal logged in variable is reset.
     $this->loggedInUser = FALSE;
 
-    if ($this->mink) {
-      $this->mink->stopSessions();
-    }
-
     // Restore original shutdown callbacks.
     if (function_exists('drupal_register_shutdown_function')) {
       $callbacks = &drupal_register_shutdown_function();