Issue #2451885 by Gábor Hojtsy: Config entities need to ship with language or are assumed undefined

core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php

@@ -83,9 +83,18 @@ abstract class ConfigEntityBase extends Entity implements ConfigEntityInterface
   /**
    * The language code of the entity's default language.
    *
+   * Assumed to be English by default. ConfigEntityStorage will set an
+   * appropriate language when creating new entities. This default applies to
+   * imported default configuration where the language code is missing. Those
+   * should be assumed to be English. All configuration entities support third
+   * party settings, so even configuration entities that do not directly
+   * store settings involving text in a human language may have such third
+   * party settings attached. This means configuration entities should be in one
+   * of the configured languages or the built-in English.
+   *
    * @var string
    */
-  protected $langcode = LanguageInterface::LANGCODE_NOT_SPECIFIED;
+  protected $langcode = 'en';
 
   /**
    * Third party entity settings.

core/modules/action/tests/action_bulk_test/config/install/views.view.test_bulk_form.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/block/tests/modules/block_test_views/test_views/views.view.test_view_block.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: test_view_block

core/modules/block/tests/modules/block_test_views/test_views/views.view.test_view_block2.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/block_content/tests/modules/block_content_test_views/test_views/views.view.test_block_content_revision_id.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/block_content/tests/modules/block_content_test_views/test_views/views.view.test_block_content_revision_revision_id.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/block_content/tests/modules/block_content_test_views/test_views/views.view.test_field_type.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/comment/tests/modules/comment_test_views/test_views/views.view.test_comment_rss.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/comment/tests/modules/comment_test_views/test_views/views.view.test_comment_user_uid.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/config/src/Tests/ConfigImporterTest.php

@@ -32,7 +32,7 @@ class ConfigImporterTest extends KernelTestBase {
    *
    * @var array
    */
-  public static $modules = array('config_test', 'system', 'config_import_test');
+  public static $modules = array('config_test', 'system', 'config_import_test', 'config_test_language');
 
   protected function setUp() {
     parent::setUp();
@@ -539,4 +539,24 @@ function testIsInstallable() {
     $this->assertTrue($this->container->get('config.storage')->exists($config_name));
   }
 
+  /**
+   * Tests imported configuration entities with and without language information.
+   */
+  function testLanguage() {
+    // Test imported configuration with implicit language code.
+    $data = $this->container->get('config.storage.installer')->read('config_test.dynamic.dotted.english');
+    $this->assertTrue(!isset($data['langcode']));
+    $this->assertEqual(
+      $this->config('config_test.dynamic.dotted.english')->get('langcode'),
+      'en'
+    );
+
+    // Test imported configuration with explicit language code.
+    $data = $this->container->get('config.storage.installer')->read('config_test.dynamic.dotted.french');
+    $this->assertEqual($data['langcode'], 'fr');
+    $this->assertEqual(
+      $this->config('config_test.dynamic.dotted.french')->get('langcode'),
+      'fr'
+    );
+  }
 }

core/modules/config/tests/config_test_language/config/install/config_test.dynamic.dotted.english.yml

+id: dotted.english
+label: Default
+weight: 0
+protected_property: Default
+# Used for testing default language code on imported config entities.
+# langcode: en

core/modules/config/tests/config_test_language/config/install/config_test.dynamic.dotted.french.yml

+id: dotted.french
+label: Default
+weight: 0
+protected_property: Default
+langcode: fr

core/modules/config/tests/config_test_language/config_test_language.info.yml

+name: 'Configuration test languages'
+type: module
+package: Testing
+version: VERSION
+core: 8.x

core/modules/content_translation/tests/modules/content_translation_test_views/test_views/views.view.test_entity_translations_link.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/dblog/tests/modules/dblog_test_views/test_views/views.view.test_dblog.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/entity_reference/tests/modules/entity_reference_test_views/test_views/views.view.test_entity_reference_view.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: test_entity_reference_view

core/modules/field/tests/modules/field_test_config/config/install/field.field.entity_test.entity_test.field_test_import.yml

 id: entity_test.entity_test.field_test_import
-langcode: und
+langcode: en
 field_name: field_test_import
 entity_type: entity_test
 bundle: entity_test

core/modules/field/tests/modules/field_test_config/config/install/field.field.entity_test.entity_test.field_test_import_2.yml

 id: entity_test.entity_test.field_test_import_2
-langcode: und
+langcode: en
 field_name: field_test_import_2
 entity_type: entity_test
 bundle: entity_test

core/modules/field/tests/modules/field_test_config/config/install/field.field.entity_test.test_bundle.field_test_import_2.yml

 id: entity_test.test_bundle.field_test_import_2
-langcode: und
+langcode: en
 field_name: field_test_import_2
 entity_type: entity_test
 bundle: test_bundle

core/modules/field/tests/modules/field_test_config/config/install/field.storage.entity_test.field_test_import.yml

 id: entity_test.field_test_import
-langcode: und
+langcode: en
 field_name: field_test_import
 entity_type: entity_test
 type: text

core/modules/field/tests/modules/field_test_config/config/install/field.storage.entity_test.field_test_import_2.yml

 id: entity_test.field_test_import_2
-langcode: und
+langcode: en
 field_name: field_test_import_2
 entity_type: entity_test
 type: text

core/modules/field/tests/modules/field_test_config/staging/field.field.entity_test.entity_test.field_test_import_staging.yml

 id: entity_test.entity_test.field_test_import_staging
 uuid: ea711065-6940-47cd-813d-618f64095481
-langcode: und
+langcode: en
 field_name: field_test_import_staging
 entity_type: entity_test
 bundle: entity_test

core/modules/field/tests/modules/field_test_config/staging/field.field.entity_test.test_bundle.field_test_import_staging_2.yml

 id: entity_test.test_bundle.field_test_import_staging_2
 uuid: f07794a2-d7cc-45b6-b40d-13cf021b5552
-langcode: und
+langcode: en
 field_name: field_test_import_staging_2
 entity_type: entity_test
 bundle: test_bundle

core/modules/field/tests/modules/field_test_config/staging/field.field.entity_test.test_bundle_2.field_test_import_staging_2.yml

 id: entity_test.test_bundle_2.field_test_import_staging_2
 uuid: 49d6dd19-5097-443d-8f00-fc79525bebce
-langcode: und
+langcode: en
 field_name: field_test_import_staging_2
 entity_type: entity_test
 bundle: test_bundle_2

core/modules/field/tests/modules/field_test_config/staging/field.storage.entity_test.field_test_import_staging.yml

 id: entity_test.field_test_import_staging
 uuid: 0bf654cc-f14a-4881-b94c-76959e47466b
-langcode: und
+langcode: en
 field_name: field_test_import_staging
 entity_type: entity_test
 type: text

core/modules/field/tests/modules/field_test_config/staging/field.storage.entity_test.field_test_import_staging_2.yml

 id: entity_test.field_test_import_staging_2
 uuid: 2165d9aa-9a0c-41a1-be02-2a49f3405c00
-langcode: und
+langcode: en
 field_name: field_test_import_staging_2
 entity_type: entity_test
 type: text

core/modules/field/tests/modules/field_test_views/test_views/views.view.test_view_fieldapi.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/field/tests/src/Unit/FieldConfigEntityUnitTest.php

@@ -243,7 +243,7 @@ public function testToArray() {
       'id' => 'test_entity_type.test_bundle.field_test',
       'uuid' => NULL,
       'status' => TRUE,
-      'langcode' => LanguageInterface::LANGCODE_NOT_SPECIFIED,
+      'langcode' => 'en',
       'field_name' => 'field_test',
       'entity_type' => 'test_entity_type',
       'bundle' => 'test_bundle',

core/modules/file/tests/modules/file_test_views/test_views/views.view.file_extension_view.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: file_extension_view

core/modules/file/tests/modules/file_test_views/test_views/views.view.test_file_user_file_data.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/image/tests/modules/image_test_views/test_views/views.view.test_image_user_image_data.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/migrate_drupal/config/install/migrate.migration.d6_field.yml

@@ -6,7 +6,7 @@ source:
   plugin: d6_field
   constants:
     entity_type: node
-    langcode: und
+    langcode: en
 process:
   entity_type: 'constants/entity_type'
   status: active

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_field_type.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_filter_node_uid_revision.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_bulk_form.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_revision_nid.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_revision_vid.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_status_extra.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/rest/tests/modules/rest_test_views/test_views/views.view.test_serializer_display_entity.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/rest/tests/modules/rest_test_views/test_views/views.view.test_serializer_display_field.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/rest/tests/modules/rest_test_views/test_views/views.view.test_serializer_node_display_field.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   config:

core/modules/statistics/tests/modules/statistics_test_views/test_views/views.view.test_statistics_integration.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_groupwise_term.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_node_term_data.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_access_perm.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_access_role.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_groupwise_user.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_plugin_argument_default_current_user.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_bulk_form.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_changed.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_data.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_name.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_relationship.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_uid_argument.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_view_argument_validate_user.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: test_view_argument_validate_user

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_view_argument_validate_username.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: test_view_argument_validate_username

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_views_handler_field_role.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_views_handler_field_user_name.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/views/tests/modules/views_test_config/test_views/views.view.entity_test_fields.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: entity_test_fields

core/modules/views/tests/modules/views_test_config/test_views/views.view.entity_test_row.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: entity_test_row

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_access_none.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: test_access_none

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_aggregate_count.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: test_aggregate_count

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_ajax_view.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: test_ajax_view

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_alias.yml

-langcode: und
+langcode: en
 status: true
 dependencies:
   module:

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_area_title.yml

-langcode: und
+langcode: en
 status: true
 dependencies: {  }
 id: test_area_title