Skip to content
Snippets Groups Projects
Verified Commit e9cde297 authored by Jess's avatar Jess
Browse files

Revert "Issue #3333401 by nicxvan, bnjmnm: Pager h4 causes accessibility flag on many pages"

This reverts commit 78cf3677.
parent b11a861d
Branches
Tags
19 merge requests!8394[warning] array_flip(): Can only flip STRING and INTEGER values, when saving a non-revisionable custom content entity,!7780issue 3443822: fix for 'No route found for the specified format html. Supported formats: json, xml.',!5013Issue #3071143: Table Render Array Example Is Incorrect,!4848Issue #1566662: Update module should send notifications on Thursdays,!4792Issue #2230689: Remove redundant "Italic" style,!4220Issue #3368223: Link field > Access to internal links is not checked on display.,!3884Issue #3356842,!3870Issue #3087868,!3812Draft: Issue #3339373 by alexpott, andypost, mondrake:...,!3686Issue #3219967 against 9.5.x,!3683Issue #2939397: Clearing AliasManager cache with root path raises warning,!3543Issue #3344259: Allow ajax dialog to have focus configurable,!3356Issue #3209129: Scrolling problems when adding a block via layout builder,!2205Quote all names in the regions section.,!2050Issue #3272969: Remove UnqiueField constraint.,!1956Issue #3268872: hook_views_invalidate_cache not called when a view is deleted,!1459Issue #3087632: menu_name max length is too long,!866Issue #2845319: The highlighting of the 'Home' menu-link does not respect query strings and fragment identifiers,!204Issue #3040556: It is not possible to react to an entity being duplicated
...@@ -33,7 +33,8 @@ ...@@ -33,7 +33,8 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}
......
...@@ -13,7 +13,8 @@ ...@@ -13,7 +13,8 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav role="navigation" aria-labelledby="{{ heading_id }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="js-pager__items"> <ul class="js-pager__items">
{% if items.previous %} {% if items.previous %}
<li> <li>
......
...@@ -11,7 +11,8 @@ ...@@ -11,7 +11,8 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}">
<h4 id="{{ heading_id }}" class="pager__heading visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{% if items.previous %} {% if items.previous %}
<li class="pager__item pager__item--previous"> <li class="pager__item pager__item--previous">
......
...@@ -35,7 +35,8 @@ ...@@ -35,7 +35,8 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}
......
...@@ -18,7 +18,8 @@ ...@@ -18,7 +18,8 @@
] ]
%} %}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav{{ attributes.addClass('pager').setAttribute('role', 'navigation').setAttribute('aria-labelledby', heading_id) }}>
<h4{{ title_attributes.addClass('visually-hidden').setAttribute('id', heading_id) }}>{{ 'Pagination'|t }}</h4>
<ul{{ content_attributes.addClass('pager__items', 'js-pager__items') }}> <ul{{ content_attributes.addClass('pager__items', 'js-pager__items') }}>
{% if items.previous %} {% if items.previous %}
{% apply spaceless %} {% apply spaceless %}
......
...@@ -31,7 +31,8 @@ ...@@ -31,7 +31,8 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav class="pager layout--content-medium" role="navigation" aria-labelledby="{{ heading_id }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}
......
...@@ -11,7 +11,8 @@ ...@@ -11,7 +11,8 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print previous item if we are not on the first page. #} {# Print previous item if we are not on the first page. #}
{% if items.previous %} {% if items.previous %}
......
...@@ -31,7 +31,8 @@ ...@@ -31,7 +31,8 @@
*/ */
#} #}
{% if items %} {% if items %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}">
<h4 id="{{ heading_id }}" class="visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{# Print first item if we are not on the first page. #} {# Print first item if we are not on the first page. #}
{% if items.first %} {% if items.first %}
......
...@@ -11,7 +11,8 @@ ...@@ -11,7 +11,8 @@
*/ */
#} #}
{% if items.previous or items.next %} {% if items.previous or items.next %}
<nav class="pager" role="navigation" aria-label="{{ 'Pagination'|t }}"> <nav class="pager" role="navigation" aria-labelledby="{{ heading_id }}">
<h4 id="{{ heading_id }}" class="pager__heading visually-hidden">{{ 'Pagination'|t }}</h4>
<ul class="pager__items js-pager__items"> <ul class="pager__items js-pager__items">
{% if items.previous %} {% if items.previous %}
<li class="pager__item pager__item--previous"> <li class="pager__item pager__item--previous">
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment