Issue #2979970 by quietone, masipila, Gábor Hojtsy: Migrate D7 vocabulary language settings

core/modules/field/src/Plugin/migrate/source/d7/FieldInstance.php

@@ -141,6 +141,34 @@ public function prepareRow(Row $row) {
         ->condition('machine_name', $vocabulary, 'IN');
       $allowed_vid = $query->execute()->fetchAllAssoc('vid');
       $row->setSourceProperty('allowed_vid', $allowed_vid);
+
+      // If there is an i18n_mode use it to determine if this field is
+      // translatable. It is TRUE only for i18n_mode 'Translate', all others are
+      // FALSE. When there is a term reference field with two vocabularies where
+      // one vocabulary is translatable and other is not the field itself is set
+      // to not translatable. Note mode '5' is not used for taxonomy but is
+      // listed here for completeness.
+      // - 0: No multilingual options.
+      // - 1: Localize. Localizable object.
+      // - 2: Fixed Language.
+      // - 4: Translate. Multilingual objects.
+      // - 5: Objects are translatable, if they have language or localizable
+      // if not)
+      if ($this->getDatabase()
+        ->schema()
+        ->fieldExists('taxonomy_vocabulary', 'i18n_mode')) {
+        $query = $this->select('taxonomy_vocabulary', 'v')
+          ->fields('v', ['i18n_mode'])
+          ->condition('machine_name', $vocabulary, 'IN');
+        $results = $query->execute()->fetchAllAssoc('i18n_mode');
+        $translatable = TRUE;
+        foreach ($results as $result) {
+          if ($result['i18n_mode'] != '4') {
+            $translatable = FALSE;
+          }
+        }
+        $row->setSourceProperty('translatable', $translatable);
+      }
     }
 
     $field_data = unserialize($row->getSourceProperty('field_data'));

core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceTest.php

@@ -104,7 +104,7 @@ public function testFieldInstances() {
     $this->assertEntity('node.page.body', 'Body', 'text_with_summary', FALSE, FALSE);
     $this->assertEntity('comment.comment_node_article.comment_body', 'Comment', 'text_long', TRUE, FALSE);
     $this->assertEntity('node.article.body', 'Body', 'text_with_summary', FALSE, TRUE);
-    $this->assertEntity('node.article.field_tags', 'Tags', 'entity_reference', FALSE, TRUE);
+    $this->assertEntity('node.article.field_tags', 'Tags', 'entity_reference', FALSE, FALSE);
     $this->assertEntity('node.article.field_image', 'Image', 'image', FALSE, TRUE);
     $this->assertEntity('comment.comment_node_blog.comment_body', 'Comment', 'text_long', TRUE, FALSE);
     $this->assertEntity('node.blog.body', 'Body', 'text_with_summary', FALSE, TRUE);
@@ -150,6 +150,11 @@ public function testFieldInstances() {
     $this->assertNull($name_field);
     $description_field = FieldConfig::load('taxonomy_term.test_vocabulary.description_field');
     $this->assertNull($description_field);
+
+    // Test the translation settings for taxonomy fields.
+    $this->assertEntity('node.article.field_vocab_fixed', 'vocab_fixed', 'entity_reference', FALSE, FALSE);
+    $this->assertEntity('node.article.field_vocab_localize', 'vocab_localize', 'entity_reference', FALSE, FALSE);
+    $this->assertEntity('node.article.field_vocab_translate', 'vocab_translate', 'entity_reference', FALSE, TRUE);
   }
 
   /**

core/modules/language/migrations/d7_language_content_taxonomy_vocabulary_settings.yml

+id: d7_language_content_taxonomy_vocabulary_settings
+label: Drupal 7 language taxonomy vocabulary settings
+migration_tags:
+  - Drupal 7
+  - Configuration
+source:
+  plugin: d7_language_content_settings_taxonomy_vocabulary
+  constants:
+    target_type: 'taxonomy_term'
+    default_langcode: 'site_default'
+process:
+  target_bundle:
+    -
+      plugin: migration_lookup
+      migration: d7_taxonomy_vocabulary
+      source: vid
+    -
+      plugin: skip_on_empty
+      method: row
+  # State is the value in the i18n_mode column of taxonomy_vocabulary table
+  # 0: No multilingual options.
+  # 1: Localize. Localizable object. Run through the localization system
+  # 2: Fixed Language. Predefined language for this object and all related ones
+  # 4: Translate. Multilingual objects, translatable but not localizable.
+  # 5: Objects are translatable (if they have language or localizable if not)
+  # Note: the Drupal 6 Per-language value (3) changed to 4 in Drupal 7.
+  language_alterable:
+    plugin: static_map
+    source: i18n_mode
+    map:
+      0: false
+      1: true
+      2: false
+      4: true
+      5: true
+  'third_party_settings/content_translation/enabled':
+    plugin: static_map
+    source: i18n_mode
+    map:
+      0: false
+      1: true
+      2: false
+      4: false
+      5: true
+  target_entity_type_id: 'constants/target_type'
+  default_langcode:
+    plugin: default_value
+    default_value: site_default
+    source: language
+destination:
+  plugin: entity:language_content_settings
+  content_translation_update_definitions:
+    - taxonomy_term
+migration_dependencies:
+  required:
+    - d7_taxonomy_vocabulary

core/modules/language/migrations/state/language.migrate_drupal.yml

 finished:
   6:
+    i18n_taxonomy: language
     locale:
       - language
       - system
     system: language
     taxonomy: language
   7:
+    i18n_taxonomy: language
     locale:
       - language
       - system

core/modules/language/src/Plugin/migrate/source/d7/LanguageContentSettingsTaxonomyVocabulary.php

+<?php
+
+namespace Drupal\language\Plugin\migrate\source\d7;
+
+use Drupal\taxonomy\Plugin\migrate\source\d7\Vocabulary;
+
+/**
+ * Drupal 7 i18n vocabularies source from database.
+ *
+ * @MigrateSource(
+ *   id = "d7_language_content_settings_taxonomy_vocabulary",
+ *   source_module = "i18n_taxonomy"
+ * )
+ */
+class LanguageContentSettingsTaxonomyVocabulary extends Vocabulary {
+
+  /**
+   * {@inheritdoc}
+   */
+  public function query() {
+    $query = parent::query();
+    if ($this->getDatabase()
+      ->schema()
+      ->fieldExists('taxonomy_vocabulary', 'i18n_mode')) {
+      $query->addField('v', 'language');
+      $query->addField('v', 'i18n_mode');
+    }
+    return $query;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public function fields() {
+    $fields = parent::fields();
+    $fields['language'] = $this->t('i18n language');
+    $fields['i18n_mode'] = $this->t('i18n mode');
+    return $fields;
+  }
+
+}

core/modules/language/tests/src/Kernel/Migrate/d7/MigrateLanguageContentTaxonomyVocabularySettingsTest.php

+<?php
+
+namespace Drupal\Tests\language\Kernel\Migrate\d7;
+
+use Drupal\language\Entity\ContentLanguageSettings;
+use Drupal\Core\Language\LanguageInterface;
+use Drupal\Tests\migrate_drupal\Kernel\d7\MigrateDrupal7TestBase;
+
+/**
+ * Tests migration of i18ntaxonomy vocabulary settings.
+ *
+ * @group migrate_drupal_7
+ */
+class MigrateLanguageContentTaxonomyVocabularySettingsTest extends MigrateDrupal7TestBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  public static $modules = [
+    'language',
+    'content_translation',
+    'taxonomy',
+    'text',
+  ];
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp() {
+    parent::setUp();
+    $this->installEntitySchema('taxonomy_term');
+    $this->executeMigrations([
+      'language',
+      'd7_taxonomy_vocabulary',
+      'd7_language_content_taxonomy_vocabulary_settings',
+    ]);
+  }
+
+  /**
+   * Tests migration of 18ntaxonomy vocabulary settings.
+   */
+  public function testLanguageContentTaxonomy() {
+    $target_entity = 'taxonomy_term';
+    // No multilingual options for terms, i18n_mode = 0.
+    $this->assertLanguageContentSettings($target_entity, 'tags', LanguageInterface::LANGCODE_NOT_SPECIFIED, FALSE, ['enabled' => FALSE]);
+    $this->assertLanguageContentSettings($target_entity, 'forums', LanguageInterface::LANGCODE_NOT_SPECIFIED, FALSE, ['enabled' => FALSE]);
+    $this->assertLanguageContentSettings($target_entity, 'vocabulary_name_much_longer_than', LanguageInterface::LANGCODE_NOT_SPECIFIED, FALSE, ['enabled' => FALSE]);
+    $this->assertLanguageContentSettings($target_entity, 'test_vocabulary', LanguageInterface::LANGCODE_NOT_SPECIFIED, FALSE, ['enabled' => FALSE]);
+    // Localize, i18n_mode = 1.
+    $this->assertLanguageContentSettings($target_entity, 'vocablocalized', LanguageInterface::LANGCODE_NOT_SPECIFIED, TRUE, ['enabled' => TRUE]);
+    // Translate, i18n_mode = 4.
+    $this->assertLanguageContentSettings($target_entity, 'vocabtranslate', LanguageInterface::LANGCODE_NOT_SPECIFIED, TRUE, ['enabled' => FALSE]);
+    // Fixed language, i18n_mode = 2.
+    $this->assertLanguageContentSettings($target_entity, 'vocabfixed', 'fr', FALSE, ['enabled' => FALSE]);
+  }
+
+  /**
+   * Asserts a content language settings configuration.
+   *
+   * @param string $target_entity
+   *   The expected target entity type.
+   * @param string $bundle
+   *   The expected bundle.
+   * @param string $default_langcode
+   *   The default language code.
+   * @param bool $language_alterable
+   *   The expected state of language alterable.
+   * @param array $third_party_settings
+   *   The content translation setting.
+   */
+  public function assertLanguageContentSettings($target_entity, $bundle, $default_langcode, $language_alterable, array $third_party_settings) {
+    $config = ContentLanguageSettings::load($target_entity . '.' . $bundle);
+    $this->assertInstanceOf(ContentLanguageSettings::class, $config);
+    $this->assertSame($target_entity, $config->getTargetEntityTypeId());
+    $this->assertSame($bundle, $config->getTargetBundle());
+    $this->assertSame($default_langcode, $config->getDefaultLangcode());
+    $this->assertSame($language_alterable, $config->isLanguageAlterable());
+    $this->assertSame($third_party_settings, $config->getThirdPartySettings('content_translation'));
+  }
+
+}

core/modules/language/tests/src/Kernel/Plugin/migrate/source/d7/LanguageContentTaxonomyVocabularySettingsTest.php

+<?php
+
+namespace Drupal\Tests\language\Kernel\Plugin\migrate\source\d7;
+
+use Drupal\Tests\taxonomy\Kernel\Plugin\migrate\source\d7\VocabularyTest;
+
+/**
+ * Tests i18ntaxonomy vocabulary setting source plugin.
+ *
+ * @covers \Drupal\language\Plugin\migrate\source\d7\LanguageContentSettingsTaxonomyVocabulary
+ *
+ * @group language
+ */
+class LanguageContentTaxonomyVocabularySettingsTest extends VocabularyTest {
+
+  /**
+   * {@inheritdoc}
+   */
+  public static $modules = ['taxonomy', 'language', 'migrate_drupal'];
+
+  /**
+   * {@inheritdoc}
+   */
+  public function providerSource() {
+    // Get the source data from parent.
+    $tests = parent::providerSource();
+
+    foreach ($tests as &$test) {
+      // Add the extra columns provided by i18n_taxonomy.
+      foreach ($test['source_data']['taxonomy_vocabulary'] as &$vocabulary) {
+        $vocabulary['language'] = 'und';
+        $vocabulary['i18n_mode'] = 2;
+      }
+      foreach ($test['expected_data'] as &$expected) {
+        $expected['language'] = 'und';
+        $expected['i18n_mode'] = 2;
+      }
+    }
+    return $tests;
+  }
+
+}

core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7Test.php

@@ -79,7 +79,7 @@ protected function getEntityCounts() {
       'file' => 3,
       'filter_format' => 7,
       'image_style' => 6,
-      'language_content_settings' => 11,
+      'language_content_settings' => 17,
       'node' => 6,
       'node_type' => 6,
       'rdf_mapping' => 8,