Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
project
drupal
Commits
d8c73958
Commit
d8c73958
authored
Dec 02, 2011
by
Nathaniel Catchpole
Browse files
Issue
#1346760
by xjm, droplet, catch: Fixed Drag and drop needs a scalable weight select element.
parent
15ddbd88
Changes
2
Hide whitespace changes
Inline
Side-by-side
core/includes/form.inc
View file @
d8c73958
...
...
@@ -3792,13 +3792,27 @@ function theme_password($variables) {
* Expand weight elements into selects.
*/
function
form_process_weight
(
$element
)
{
for
(
$n
=
(
-
1
*
$element
[
'#delta'
]);
$n
<=
$element
[
'#delta'
];
$n
++
)
{
$weights
[
$n
]
=
$n
;
}
$element
[
'#options'
]
=
$weights
;
$element
[
'#type'
]
=
'select'
;
$element
[
'#is_weight'
]
=
TRUE
;
$element
+=
element_info
(
'select'
);
// If the number of options is small enough, use a select field.
$max_elements
=
variable_get
(
'drupal_weight_select_max'
,
DRUPAL_WEIGHT_SELECT_MAX
);
if
(
$element
[
'#delta'
]
<=
$max_elements
)
{
$element
[
'#type'
]
=
'select'
;
for
(
$n
=
(
-
1
*
$element
[
'#delta'
]);
$n
<=
$element
[
'#delta'
];
$n
++
)
{
$weights
[
$n
]
=
$n
;
}
$element
[
'#options'
]
=
$weights
;
$element
+=
element_info
(
'select'
);
}
// Otherwise, use a text field.
else
{
$element
[
'#type'
]
=
'textfield'
;
// Use a field big enough to fit most weights.
$element
[
'#size'
]
=
10
;
$element
[
'#element_validate'
]
=
array
(
'element_validate_integer'
);
$element
+=
element_info
(
'textfield'
);
}
return
$element
;
}
...
...
core/modules/system/system.module
View file @
d8c73958
...
...
@@ -45,6 +45,13 @@
*/
const
DRUPAL_REQUIRED
=
2
;
/**
* Maximum number of values in a weight select element.
*
* If the number of values is over the maximum, a text field is used instead.
*/
const
DRUPAL_WEIGHT_SELECT_MAX
=
100
;
/**
* Return only visible regions.
*
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment