Issue #2915534 by drpal, nod_: JS codestyle: prefer-rest-params

core/.eslintrc.passing.json

@@ -12,7 +12,6 @@
     "new-cap": "off",
     "max-len": "off",
     "default-case": "off",
-    "camelcase": "off",
-    "prefer-rest-params": "off"
+    "camelcase": "off"
   }
 }

core/misc/debounce.es6.js

@@ -29,9 +29,8 @@
 Drupal.debounce = function (func, wait, immediate) {
   let timeout;
   let result;
-  return function () {
+  return function (...args) {
     const context = this;
-    const args = arguments;
     const later = function () {
       timeout = null;
       if (!immediate) {

core/misc/debounce.js

@@ -9,8 +9,11 @@ Drupal.debounce = function (func, wait, immediate) {
   var timeout = void 0;
   var result = void 0;
   return function () {
+    for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
+      args[_key] = arguments[_key];
+    }
+
     var context = this;
-    var args = arguments;
     var later = function later() {
       timeout = null;
       if (!immediate) {

core/misc/dialog/dialog.ajax.es6.js

@@ -42,8 +42,8 @@
 
       const originalClose = settings.dialog.close;
       // Overwrite the close method to remove the dialog on closing.
-      settings.dialog.close = function (event) {
-        originalClose.apply(settings.dialog, arguments);
+      settings.dialog.close = function (event, ...args) {
+        originalClose.apply(settings.dialog, [event, ...args]);
         $(event.target).remove();
       };
     },

core/misc/dialog/dialog.ajax.js

@@ -26,7 +26,11 @@
       var originalClose = settings.dialog.close;
 
       settings.dialog.close = function (event) {
-        originalClose.apply(settings.dialog, arguments);
+        for (var _len = arguments.length, args = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
+          args[_key - 1] = arguments[_key];
+        }
+
+        originalClose.apply(settings.dialog, [event].concat(args));
         $(event.target).remove();
       };
     },

core/misc/drupal.es6.js

@@ -559,10 +559,9 @@ window.Drupal = { behaviors: {}, locale: {} };
    *   Any data the theme function returns. This could be a plain HTML string,
    *   but also a complex object.
    */
-  Drupal.theme = function (func) {
-    const args = Array.prototype.slice.apply(arguments, [1]);
+  Drupal.theme = function (func, ...args) {
     if (func in Drupal.theme) {
-      return Drupal.theme[func].apply(this, args);
+      return Drupal.theme[func](...args);
     }
   };
 

core/misc/drupal.js

@@ -181,9 +181,14 @@ window.Drupal = { behaviors: {}, locale: {} };
   };
 
   Drupal.theme = function (func) {
-    var args = Array.prototype.slice.apply(arguments, [1]);
     if (func in Drupal.theme) {
-      return Drupal.theme[func].apply(this, args);
+      var _Drupal$theme;
+
+      for (var _len = arguments.length, args = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
+        args[_key - 1] = arguments[_key];
+      }
+
+      return (_Drupal$theme = Drupal.theme)[func].apply(_Drupal$theme, args);
     }
   };