Issue #3314260 by quietone, avpaderno, rakesh.drupal, ravi.shankar,...

Issue #3314260 by quietone, avpaderno, rakesh.drupal, ravi.shankar, chaitanyadessai, smustgrave, catch, Spokje: Replace t() calls inside of Controllers that do not use StringTranslationTrait

(cherry picked from commit d2cf8e52)

core/modules/system/src/Controller/SystemController.php

@@ -334,7 +334,7 @@ public function themesPage() {
               'attributes' => ['title' => $this->t('Set @theme as default theme', ['@theme' => $theme->info['name']])],
             ];
           }
-          $admin_theme_options[$theme->getName()] = $theme->info['name'] . ($theme->isExperimental() ? ' (' . t('Experimental') . ')' : '');
+          $admin_theme_options[$theme->getName()] = $theme->info['name'] . ($theme->isExperimental() ? ' (' . $this->t('Experimental') . ')' : '');
         }
         else {
           $theme->operations[] = [

core/modules/update/src/Controller/UpdateController.php

@@ -77,10 +77,10 @@ public function updateStatus() {
   public function updateStatusManually() {
     $this->updateManager->refreshUpdateData();
     $batch_builder = (new BatchBuilder())
-      ->setTitle(t('Checking available update data'))
+      ->setTitle($this->t('Checking available update data'))
       ->addOperation([$this->updateManager, 'fetchDataBatch'], [])
       ->setProgressMessage(t('Trying to check available update data ...'))
-      ->setErrorMessage(t('Error checking available update data.'))
+      ->setErrorMessage($this->t('Error checking available update data.'))
       ->setFinishCallback('update_fetch_data_finished');
     batch_set($batch_builder->toArray());
     return batch_process('admin/reports/updates');

core/modules/views_ui/src/Controller/ViewsUIController.php

@@ -73,7 +73,7 @@ public function reportFields() {
       }
     }
 
-    $header = [t('Field name'), t('Used in')];
+    $header = [$this->t('Field name'), $this->t('Used in')];
     $rows = [];
     foreach ($fields as $field_name => $views) {
       $rows[$field_name]['data'][0]['data']['#plain_text'] = $field_name;
@@ -94,7 +94,7 @@ public function reportFields() {
       '#type' => 'table',
       '#header' => $header,
       '#rows' => $rows,
-      '#empty' => t('No fields have been used in views yet.'),
+      '#empty' => $this->t('No fields have been used in views yet.'),
     ];
 
     return $output;
@@ -126,9 +126,9 @@ public function reportPlugins() {
     ksort($rows);
     return [
       '#type' => 'table',
-      '#header' => [t('Type'), t('Name'), t('Provided by'), t('Used in')],
+      '#header' => [$this->t('Type'), $this->t('Name'), $this->t('Provided by'), $this->t('Used in')],
       '#rows' => $rows,
-      '#empty' => t('There are no enabled views.'),
+      '#empty' => $this->t('There are no enabled views.'),
     ];
   }