Issue #3187643 by spokje, acbramley, quietone: Make Node views wizard buildFilters more efficient

core/modules/node/src/Plugin/views/wizard/Node.php

@@ -277,17 +277,13 @@ protected function buildFilters(&$form, FormStateInterface $form_state) {
     $tag_fields = [];
     foreach ($bundles as $bundle) {
       $display = $this->entityDisplayRepository->getFormDisplay($this->entityTypeId, $bundle);
-      $taxonomy_fields = array_filter($this->entityFieldManager->getFieldDefinitions($this->entityTypeId, $bundle), function (FieldDefinitionInterface $field_definition) {
-        return $field_definition->getType() == 'entity_reference' && $field_definition->getSetting('target_type') == 'taxonomy_term';
-      });
-      foreach ($taxonomy_fields as $field_name => $field) {
-        $widget = $display->getComponent($field_name);
-        // We define "tag-like" taxonomy fields as ones that use the
-        // "Autocomplete (Tags style)" widget.
-        if (!empty($widget) && $widget['type'] == 'entity_reference_autocomplete_tags') {
-          $tag_fields[$field_name] = $field;
+      $tag_fields += array_filter($this->entityFieldManager->getFieldDefinitions($this->entityTypeId, $bundle), function (FieldDefinitionInterface $field_definition) use ($display) {
+        if ($field_definition->getType() == 'entity_reference' && $field_definition->getSetting('target_type') == 'taxonomy_term') {
+          $widget = $display->getComponent($field_definition->getName());
+          return isset($widget['type']) && $widget['type'] == 'entity_reference_autocomplete_tags';
         }
-      }
+        return FALSE;
+      });
     }
     if (!empty($tag_fields)) {
       // If there is more than one "tag-like" taxonomy field available to