Issue #2670454 by Lendude, daffie, alexpott: Deprecate BC layer for #2670360

core/modules/block_content/tests/src/Kernel/BlockContentAccessHandlerTest.php

@@ -56,7 +56,6 @@ class BlockContentAccessHandlerTest extends KernelTestBase {
    */
   protected function setUp() {
     parent::setUp();
-    $this->installSchema('system', ['sequence']);
     $this->installSchema('system', ['sequences']);
     $this->installSchema('user', ['users_data']);
     $this->installEntitySchema('user');

core/modules/block_content/tests/src/Kernel/BlockContentDeletionTest.php

@@ -24,7 +24,6 @@ class BlockContentDeletionTest extends KernelTestBase {
    */
   public function setUp() {
     parent::setUp();
-    $this->installSchema('system', ['sequence']);
     $this->installEntitySchema('user');
     $this->installEntitySchema('block_content');
   }

core/modules/block_content/tests/src/Kernel/BlockContentDeriverTest.php

@@ -24,7 +24,6 @@ class BlockContentDeriverTest extends KernelTestBase {
    */
   public function setUp() {
     parent::setUp();
-    $this->installSchema('system', ['sequence']);
     $this->installEntitySchema('user');
     $this->installEntitySchema('block_content');
   }

core/modules/block_content/tests/src/Kernel/BlockContentEntityReferenceSelectionTest.php

@@ -67,7 +67,6 @@ class BlockContentEntityReferenceSelectionTest extends KernelTestBase {
    */
   public function setUp() {
     parent::setUp();
-    $this->installSchema('system', ['sequence']);
     $this->installSchema('system', ['sequences']);
     $this->installEntitySchema('user');
     $this->installEntitySchema('block_content');

core/modules/language/tests/src/Kernel/ConfigurableLanguageManagerTest.php

@@ -38,7 +38,6 @@ class ConfigurableLanguageManagerTest extends LanguageTestBase {
   protected function setUp() {
     parent::setUp();
 
-    $this->installSchema('system', ['sequence']);
     $this->installEntitySchema('user');
 
     $this->languageNegotiator = $this->container->get('language_negotiator');

core/modules/menu_link_content/tests/src/Kernel/Migrate/d6/MigrateMenuLinkTranslationTest.php

@@ -30,7 +30,6 @@ class MigrateMenuLinkTranslationTest extends MigrateDrupal6TestBase {
   protected function setUp() {
     parent::setUp();
     $this->migrateContent();
-    $this->installSchema('system', ['router']);
     $this->installEntitySchema('menu_link_content');
     $this->executeMigrations([
       'language',

core/modules/views/tests/src/Kernel/ViewsKernelTestBase.php

@@ -42,7 +42,7 @@ abstract class ViewsKernelTestBase extends KernelTestBase {
   protected function setUp($import_test_views = TRUE) {
     parent::setUp();
 
-    $this->installSchema('system', ['router', 'sequences', 'key_value_expire']);
+    $this->installSchema('system', ['sequences', 'key_value_expire']);
     $this->setUpFixtures();
 
     if ($import_test_views) {

core/tests/Drupal/KernelTests/KernelTestBase.php

@@ -713,6 +713,10 @@ protected function installConfig($modules) {
    *
    * @throws \LogicException
    *   If $module is not enabled or the table schema cannot be found.
+   *
+   * @deprecated Special handling of system module schemas has been deprecated
+   *   in Drupal 8.7.x, remove any calls to this method that use invalid schema
+   *   names.
    */
   protected function installSchema($module, $tables) {
     // drupal_get_module_schema() is technically able to install a schema
@@ -728,10 +732,10 @@ protected function installSchema($module, $tables) {
       $schema = drupal_get_module_schema($module, $table);
       if (empty($schema)) {
         // BC layer to avoid some contrib tests to fail.
-        // @todo Remove the BC layer before 8.1.x release.
         // @see https://www.drupal.org/node/2670360
         // @see https://www.drupal.org/node/2670454
         if ($module == 'system') {
+          @trigger_error('Special handling of system module schemas in \Drupal\KernelTests\KernelTestBase::installSchema has been deprecated in Drupal 8.7.x, remove any calls to this method that use invalid schema names.', E_USER_DEPRECATED);
           continue;
         }
         throw new \LogicException("$module module does not define a schema for table '$table'.");