Issue #3478204 by quietone, larowlan: Fix MissingParamType in core/lib/Drupal/Core

core/core.api.php

@@ -2078,7 +2078,7 @@ function hook_condition_info_alter(array &$definitions) {
  * this hook. All core modules use MailManagerInterface->mail() for messaging,
  * it is best practice but not mandatory in contributed modules.
  *
- * @param $message
+ * @param array $message
  *   An array containing the message data. Keys in this array include:
  *   - 'id':
  *     The MailManagerInterface->mail() id of the message. Look at module source
@@ -2130,9 +2130,9 @@ function hook_mail_alter(&$message) {
  * unlike hook_mail_alter(), is only called on the $module argument to
  * MailManagerInterface->mail(), not all modules.
  *
- * @param $key
+ * @param string $key
  *   An identifier of the mail.
- * @param $message
+ * @param array $message
  *   An array to be filled in. Elements in this array include:
  *   - id: An ID to identify the mail sent. Look at module source code or
  *     MailManagerInterface->mail() for possible id values.
@@ -2153,7 +2153,7 @@ function hook_mail_alter(&$message) {
  *   - headers: Associative array containing mail headers, such as From,
  *     Sender, MIME-Version, Content-Type, etc.
  *     MailManagerInterface->mail() pre-fills several headers in this array.
- * @param $params
+ * @param array $params
  *   An array of parameters supplied by the caller of
  *   MailManagerInterface->mail().
  *
@@ -2214,7 +2214,7 @@ function hook_mail_backend_info_alter(&$info) {
 /**
  * Alter the default country list.
  *
- * @param $countries
+ * @param string[][] $countries
  *   The associative array of countries keyed by two-letter country code.
  *
  * @see \Drupal\Core\Locale\CountryManager::getList()
@@ -2339,7 +2339,7 @@ function hook_config_import_steps_alter(&$sync_steps, \Drupal\Core\Config\Config
  *
  * For adding new data types use configuration schema YAML files instead.
  *
- * @param $definitions
+ * @param array $definitions
  *   Associative array of configuration type definitions keyed by schema type
  *   names. The elements are themselves array with information about the type.
  *

core/lib/Drupal/Core/Ajax/CssCommand.php

@@ -50,9 +50,9 @@ public function __construct($selector, array $css = []) {
   /**
    * Adds a property/value pair to the CSS to be added to this element.
    *
-   * @param $property
+   * @param string $property
    *   The CSS property to be changed.
-   * @param $value
+   * @param string $value
    *   The new value of the CSS property.
    *
    * @return $this

core/lib/Drupal/Core/Asset/CssOptimizer.php

@@ -109,11 +109,11 @@ protected function processFile($css_asset) {
    * it is not on the AssetOptimizerInterface, so any future refactoring can
    * make it protected.
    *
-   * @param $file
+   * @param string $file
    *   Name of the stylesheet to be processed.
-   * @param $optimize
+   * @param bool|null $optimize
    *   Defines if CSS contents should be compressed or not.
-   * @param $reset_base_path
+   * @param bool $reset_base_path
    *   Used internally to facilitate recursive resolution of @import commands.
    *
    * @return string
@@ -203,9 +203,9 @@ protected function loadNestedFile($matches) {
   /**
    * Processes the contents of a stylesheet for aggregation.
    *
-   * @param $contents
+   * @param string $contents
    *   The contents of the stylesheet.
-   * @param $optimize
+   * @param bool $optimize
    *   (optional) Boolean whether CSS contents should be minified. Defaults to
    *   FALSE.
    *

core/lib/Drupal/Core/Asset/LibraryDiscoveryCollector.php

@@ -124,7 +124,7 @@ protected function getLibraryDefinitions($extension) {
    *   The name of the extension for which library definitions will be extended.
    * @param string $library_name
    *   The name of the library whose definitions is to be extended.
-   * @param $library_definition
+   * @param array $library_definition
    *   The library definition to be extended.
    *
    * @return array

core/lib/Drupal/Core/Batch/BatchStorage.php

@@ -188,7 +188,7 @@ protected function ensureTableExists() {
    * yet the query failed, then the batch is stale and the exception needs to
    * propagate.
    *
-   * @param $e
+   * @param \Exception $e
    *   The exception.
    *
    * @throws \Exception

core/lib/Drupal/Core/Cache/ApcuBackendFactory.php

@@ -49,7 +49,7 @@ public function __construct($root, $site_path, CacheTagsChecksumInterface $check
   /**
    * Gets ApcuBackend for the specified cache bin.
    *
-   * @param $bin
+   * @param string $bin
    *   The cache bin for which the object is created.
    *
    * @return \Drupal\Core\Cache\ApcuBackend

core/lib/Drupal/Core/Cache/DatabaseBackend.php

@@ -458,7 +458,7 @@ protected function ensureBinExists() {
    * yet the query failed, then the cache is stale and the exception needs to
    * propagate.
    *
-   * @param $e
+   * @param \Exception $e
    *   The exception.
    * @param string|null $table_name
    *   The table name. Defaults to $this->bin.

core/lib/Drupal/Core/Cache/DatabaseBackendFactory.php

@@ -53,7 +53,7 @@ public function __construct(
   /**
    * Gets DatabaseBackend for the specified cache bin.
    *
-   * @param $bin
+   * @param string $bin
    *   The cache bin for which the object is created.
    *
    * @return \Drupal\Core\Cache\DatabaseBackend

core/lib/Drupal/Core/Cache/PhpBackendFactory.php

@@ -28,7 +28,7 @@ public function __construct(CacheTagsChecksumInterface $checksum_provider, prote
   /**
    * Gets PhpBackend for the specified cache bin.
    *
-   * @param $bin
+   * @param string $bin
    *   The cache bin for which the object is created.
    *
    * @return \Drupal\Core\Cache\PhpBackend

core/lib/Drupal/Core/Config/BootstrapConfigStorageFactory.php

@@ -13,7 +13,7 @@ class BootstrapConfigStorageFactory {
   /**
    * Returns a configuration storage implementation.
    *
-   * @param $class_loader
+   * @param \Composer\Autoload\ClassLoader $class_loader
    *   The class loader. Normally Composer's ClassLoader, as included by the
    *   front controller, but may also be decorated.
    *

core/lib/Drupal/Core/Config/Entity/ConfigDependencyManager.php

@@ -311,7 +311,7 @@ public function setData(array $data) {
   /**
    * Updates one of the lightweight ConfigEntityDependency objects.
    *
-   * @param $name
+   * @param string $name
    *   The configuration dependency name.
    * @param array $dependencies
    *   The configuration dependencies. The array is structured like this:

core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php

@@ -313,9 +313,9 @@ protected function buildCacheId($id) {
   /**
    * Invokes a hook on behalf of the entity.
    *
-   * @param $hook
+   * @param string $hook
    *   One of 'presave', 'insert', 'update', 'predelete', or 'delete'.
-   * @param $entity
+   * @param \Drupal\Core\Entity\EntityInterface $entity
    *   The entity object.
    */
   protected function invokeHook($hook, EntityInterface $entity) {

core/lib/Drupal/Core/Config/Entity/ConfigEntityStorageInterface.php

@@ -73,7 +73,7 @@ public function loadOverrideFree($id);
   /**
    * Loads one or more entities in their original form without overrides.
    *
-   * @param $ids
+   * @param string[]|null $ids
    *   An array of entity IDs, or NULL to load all entities.
    *
    * @return \Drupal\Core\Entity\EntityInterface[]

core/lib/Drupal/Core/Config/PreExistingConfigException.php

@@ -47,7 +47,7 @@ public function getExtension() {
   /**
    * Creates an exception for an extension and a list of configuration objects.
    *
-   * @param $extension
+   * @param string $extension
    *   The name of the extension that is being installed.
    * @param array $config_objects
    *   A list of configuration objects that already exist in active

core/lib/Drupal/Core/Config/Schema/ArrayElement.php

@@ -162,7 +162,7 @@ protected function createElement($definition, $value, $key) {
    * @param array $definition
    *   The base type definition array, for which a data definition should be
    *   created.
-   * @param $value
+   * @param mixed $value
    *   The value of the configuration element.
    * @param string $key
    *   The key of the contained element.

core/lib/Drupal/Core/Config/Schema/ConfigSchemaDiscovery.php

@@ -23,7 +23,7 @@ class ConfigSchemaDiscovery implements DiscoveryInterface {
   /**
    * Constructs a ConfigSchemaDiscovery object.
    *
-   * @param $schema_storage
+   * @param \Drupal\Core\Config\StorageInterface $schema_storage
    *   The storage object to use for reading schema data.
    */
   public function __construct(StorageInterface $schema_storage) {

core/lib/Drupal/Core/Config/Schema/TypedConfigInterface.php

@@ -35,7 +35,7 @@ public function getElements();
   /**
    * Gets a contained typed configuration element.
    *
-   * @param $name
+   * @param string $name
    *   The name of the property to get; e.g., 'title' or 'name'. Nested
    *   elements can be get using multiple dot delimited names, for example,
    *   'page.front'.

core/lib/Drupal/Core/Config/TypedConfigManagerInterface.php

@@ -34,7 +34,7 @@ public function get($name);
    * @param array $definition
    *   The base type definition array, for which a data definition should be
    *   created.
-   * @param $value
+   * @param mixed $value
    *   Optional value of the configuration element.
    * @param string $name
    *   Optional name of the configuration element.

core/lib/Drupal/Core/Config/UnmetDependenciesException.php

@@ -81,7 +81,7 @@ public function getTranslatedMessage(TranslationInterface $string_translation, $
   /**
    * Creates an exception for an extension and a list of configuration objects.
    *
-   * @param $extension
+   * @param string $extension
    *   The name of the extension that is being installed.
    * @param array $config_objects
    *   A list of configuration keyed by configuration name, with unmet

core/lib/Drupal/Core/Datetime/DateFormatterInterface.php

@@ -87,7 +87,7 @@ public function getSampleDateFormats($langcode = NULL, $timestamp = NULL, $timez
   /**
    * Formats the time difference from the current request time to a timestamp.
    *
-   * @param $timestamp
+   * @param int $timestamp
    *   A UNIX timestamp to compare against the current request time.
    * @param array $options
    *   (optional) An associative array with additional options. The following
@@ -117,7 +117,7 @@ public function formatTimeDiffUntil($timestamp, $options = []);
   /**
    * Formats the time difference from a timestamp to the current request time.
    *
-   * @param $timestamp
+   * @param int $timestamp
    *   A UNIX timestamp to compare against the current request time.
    * @param array $options
    *   (optional) An associative array with additional options. The following