Skip to content
Snippets Groups Projects
Verified Commit ac0a3c1f authored by Dave Long's avatar Dave Long
Browse files

Issue #3466524 by catch: ModuleConfigureRouteTest is slow

(cherry picked from commit d3b144d3)
parent 678119bb
No related branches found
No related tags found
3 merge requests!11769Issue #3517987: Add option to contextual filters to encode slashes in query parameter.,!11185Issue #3477324 by andypost, alexpott: Fix usage of str_getcsv() and fgetcsv() for PHP 8.4,!9944Issue #3483353: Consider making the createCopy config action optionally fail...
Pipeline #247027 passed with warnings
Pipeline: drupal

#247052

    Pipeline: drupal

    #247047

      Pipeline: drupal

      #247038

        +1
        ......@@ -47,17 +47,24 @@ protected function setUp(): void {
        /**
        * Tests if the module configure routes exists.
        *
        * @dataProvider coreModuleListDataProvider
        */
        public function testModuleConfigureRoutes(string $module_name): void {
        public function testModuleConfigureRoutes(): void {
        foreach (static::coreModuleListDataProvider() as $module_name => $info) {
        $this->doTestModuleConfigureRoutes($module_name);
        }
        }
        /**
        * Checks the configure route for a single module.
        */
        protected function doTestModuleConfigureRoutes(string $module_name): void {
        $module_info = $this->moduleInfo[$module_name]->info;
        if (!isset($module_info['configure'])) {
        $this->markTestSkipped("$module_name has no configure route");
        return;
        }
        $module_lifecycle = $module_info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER];
        if (isset($module_lifecycle) && $module_lifecycle === ExtensionLifecycle::DEPRECATED) {
        $this->markTestSkipped("$module_name is $module_lifecycle");
        return;
        }
        $this->container->get('module_installer')->install([$module_name]);
        $this->assertModuleConfigureRoutesExist($module_name, $module_info);
        ......@@ -70,17 +77,24 @@ public function testModuleConfigureRoutes(string $module_name): void {
        * deprecated module doesn't trigger a deprecation notice.
        *
        * @group legacy
        *
        * @dataProvider coreModuleListDataProvider
        */
        public function testDeprecatedModuleConfigureRoutes(string $module_name): void {
        public function testDeprecatedModuleConfigureRoutes(): void {
        foreach (static::coreModuleListDataProvider() as $module_name => $info) {
        $this->doTestDeprecatedModuleConfigureRoutes($module_name);
        }
        }
        /**
        * Check the configure route for a single module.
        */
        protected function doTestDeprecatedModuleConfigureRoutes(string $module_name): void {
        $module_info = $this->moduleInfo[$module_name]->info;
        if (!isset($module_info['configure'])) {
        $this->markTestSkipped("$module_name has no configure route");
        return;
        }
        $module_lifecycle = $module_info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER];
        if (isset($module_lifecycle) && $module_lifecycle !== ExtensionLifecycle::DEPRECATED) {
        $this->markTestSkipped("$module_name is not $module_lifecycle");
        return;
        }
        $this->container->get('module_installer')->install([$module_name]);
        $this->assertModuleConfigureRoutesExist($module_name, $module_info);
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Finish editing this message first!
        Please register or to comment